missing keys should throw InvalidNode, not BadConversion

Fixes GH jbeder#1274
SpexAI · Nov 1, 2024 · 477966f · 477966f
1 parent c2bec4c
commit 477966f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/include/yaml-cpp/node/impl.h b/include/yaml-cpp/node/impl.h
@@ -124,8 +124,8 @@ struct as_if<T, void> {
   const Node& node;
 
   T operator()() const {
-    if (!node.m_pNode)
-      throw TypedBadConversion<T>(node.Mark());
+    if (!node.m_pNode) // no fallback
+      throw InvalidNode(node.m_invalidKey);
 
     T t;
     if (convert<T>::decode(node, t))

diff --git a/test/integration/load_node_test.cpp b/test/integration/load_node_test.cpp
@@ -375,6 +375,12 @@ TEST(NodeSpecTest, InfiniteLoopNodes) {
   EXPECT_THROW(LoadAll(R"(,)"), ParserException);
 }
 
+TEST(NodeTest, LoadMissingKey) {
+  Node node;
+  node["foo"] = "value";
+  EXPECT_THROW(node.["bar"], InvalidNode);
+}
+
 struct NewLineStringsTestCase {
   std::string input;
   std::string expected_content;