Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup & port internationalization #6

Open
MulverineX opened this issue May 17, 2022 · 3 comments
Open

Setup & port internationalization #6

MulverineX opened this issue May 17, 2022 · 3 comments
Assignees

Comments

@MulverineX
Copy link
Member

No description provided.

@SPGoding
Copy link
Member

SPGoding commented May 17, 2022

Internationalization will probably be achieved by attributes -- does this mean we are better off putting this inside the monorepo so that the locale files can be updated together with vanilla-mcdoc? Or do we want to keep a separate list of locale files inside this repo? cc @misode

@MulverineX
Copy link
Member Author

IMO it's still worth keeping this in its own repository

@SPGoding
Copy link
Member

SPGoding commented May 18, 2022

I've thought a bit about i18n. I suggest a GHA that generates the english locales and pushes that (to a separate branch?) So for example:

{
  "::data::loot_table::LootTable.pools": "Pools",
  "::data::loot_table::LootTable.pools#doc": "The pools of the loot table",
  "::data::loot_table::LootPool.bonus_rolls": "Bonus rolls"
}

Misode, on Discord

@MulverineX MulverineX moved this from Todo to In Progress in mcdoc refactor May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants