Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork of composite-primary-keys doesn't work with current ActiveRecord #17

Closed
wrs opened this issue Jan 23, 2013 · 5 comments
Closed

Fork of composite-primary-keys doesn't work with current ActiveRecord #17

wrs opened this issue Jan 23, 2013 · 5 comments

Comments

@wrs
Copy link

wrs commented Jan 23, 2013

I'm trying to get Squash to run on Heroku. I have several fixes going, but here's one that I'm not sure what to do about. I get "production database not configured" trying to start the server. That's because the fork-of-a-fork of composite-primary-keys contains a monkey patch of ActiveRecord::Base.establish_connection that is out of date with current ActiveRecord code. The original drnic repo has working code, but I don't know whether it's safe to change to that.

The simplest solution would be for you to update your fork of CPK. Is that possible?

The code in question is here:
https://github.com/drnic/composite_primary_keys/blob/master/lib/composite_primary_keys/connection_adapters/abstract/connection_specification_changes.rb

@RISCfuture
Copy link
Contributor

Fixed with c70c626

@williscool
Copy link

Hey @wrs did you get this working on Heorku?

What patches did you have to make to get it working? Are they upstream yet?

@wrs
Copy link
Author

wrs commented Jan 26, 2013

Still working on it--seems close. I will submit a pull request when I have it going.

@ralfschimmel
Copy link

Also interested in running this on heroku, looking forward to your pull req @wrs

@wrs
Copy link
Author

wrs commented Jan 30, 2013

@williscool @ralfschimmel See #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants