Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create issue on Github from Squash bug #25

Closed
davegoldberg opened this issue Jan 25, 2013 · 18 comments
Closed

Ability to create issue on Github from Squash bug #25

davegoldberg opened this issue Jan 25, 2013 · 18 comments
Labels

Comments

@davegoldberg
Copy link

Hey there-

We're moving from Airbrake to Squash and one thing we really miss is the ability to create Github issues directly from the web interface (or email). Happy to dig in and submit a PR if this is something that seems interesting to y'all. Would just need some details on where you'd like the link to live in UI.
Screen Shot 2013-01-25 at 11 03 27 AM

Thanks!

@RISCfuture
Copy link
Contributor

Good feature suggestion. I'm also happy to do it once I have some time (soon-ish?). A good way to start is to grep for Service::JIRA. You'd create a Service::GitHub in the same vein, add metadata to the Project model storing GitHub credentials, alter the Views::Projects::Edit form so the user can set those credentials, and then edit the Views::Bugs::Show#management method so that the form includes the ability to create a GitHub issue.

@davegoldberg
Copy link
Author

@RISCfuture Great. Will spend some time with it and hopefully come up with something serviceable.

@williscool
Copy link

I was just about to ask you if could you make it a generic issues hook or something like that but sounds like Service is that correct?

I would like for it to integrate with gitlab

http://gitlab.org/
https://github.com/gitlabhq/gitlabhq

@RISCfuture
Copy link
Contributor

Service isn't really an abstract superclass and doesn't really encapsulate any shared behavior. It's just a place where I can stick modules that relate to third-party integration. All the different classes under Service don't really conform to any interface. It might be worthwhile at some point to investigate pulling out common behavior into a superclass, but right now there are only a small number of integrations and they're so different that it doesn't make sense.

Maybe with the addition of GitHub integration it's time to start thinking about that? :)

@williscool
Copy link

Ah I see thanks. Let me know if you get around to this.

Gitlab has good api support for these kinds of things

https://github.com/gitlabhq/gitlabhq/blob/master/doc/api/issues.md

@williscool
Copy link

I may get a chance to work on this as a part of an internal company hackathon.

If you guys have any ideas you would like to see in it (i.e. I plan to make it generic so it could easily be changed to work with redmine, gitlab, or github)

let me know

@extcode
Copy link

extcode commented Jan 28, 2013

Hi. Can you explain your goal, how to work with redmine / gitlab? I'm using gitlab, redmine and errbit and evaluating squash.

@RISCfuture
Copy link
Contributor

Awesome! If you want more real-time help during the Hackathon, just let me know; we can exchange contact info.

@davegoldberg
Copy link
Author

Sweet! Will put my Service based implementation on hold until after the hackathon.

@williscool
Copy link

Will do if I get the chance thanks for offering @RISCfuture it starts Thursday so I'll let you guys know then I'll take and need all the help I can get

@williscool
Copy link

Alright guys I got gitlab setup on and internal vm and im about to start working on Squash.

Wish me luck!

@williscool
Copy link

hey @RISCfuture you message me your contact info?

I'm having trouble getting it setup.

I had it running one way that would let me ge all the way to the bug list on a project but then error out when I clicked on one.

Now it just can't //= require squash_javascript

@RISCfuture
Copy link
Contributor

Oh, no, and GitHub doesn't seem to have a PM feature. You can email me at the RubyGems address I have on file, [email protected], or continue to use this issue.

@williscool
Copy link

Yeah sorry about that I forgot they got rid of it

thanks,

I got it working with this, though

https://github.com/RISCfuture/ruby-git/pull/2

about to start working on the issues intergration now.

@williscool
Copy link

Leaving these here for reference

Edit: after further research
http://stackoverflow.com/questions/9572791/debugging-activeresource

activeresource probably isnt a long term solution

https://github.com/jnunemaker/httparty is better but does less magic for you

also https://github.com/CrowdFlower/hyro

@williscool
Copy link

Also most there with gitlab and redmine

this was a huge help

https://github.com/remiprev/her

will submit pull soon

@williscool
Copy link

here is my pull request

#42

@RISCfuture
Copy link
Contributor

Continuing in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants