-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specs don't run on a clean checkout #62
Comments
There's already a script in the |
Interesting... that's not likely to be immediately helpful in the context of Travis since it does all the combinations itself to track the results in the matrix. Do the LDAP tests need an LDAP server running to work? I wonder if it makes sense to do what Rails does here (for example, when testing ActiveRecord against different DBs). That is, feed in these configs as environment variables and have the test suite itself do the right thing for that scenario. The |
LDAP tests are all mocked; no server is required. The main point of |
Agreed. The real benefit of Travis for a project maintainer, IMO, is seeing if a pull request passes or not. |
Based on the output from this build (a test run for future pull request #59), it seems that it expects the config files to be set up with certain values which only get written out by
setup.rb
.Are there any downsides you foresee to giving all configs sane default values, prior to a
setup.rb
run, @RISCfuture? Alternatively (and possibly more desirably), the tests could setup the configs as they expect them (i.e. if a test relies on authentication being set to "password", it should just set it up front for that test).The text was updated successfully, but these errors were encountered: