Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImagePost.js does not show comment count #243

Closed
Sebastian-Webster opened this issue Oct 10, 2023 · 0 comments · Fixed by #244
Closed

ImagePost.js does not show comment count #243

Sebastian-Webster opened this issue Oct 10, 2023 · 0 comments · Fixed by #244
Assignees
@Sebastian-Webster
Labels
bug Something isn't working
Milestone
Before Release

Comments

@Sebastian-Webster
Copy link
Member

This is because of a backend related change: SquareTable/SocialSquare-Backend#190
The backend now sends a comment count instead of a comments array. The frontend displays the comments from commentsArray.length, and the length property of a number in JS is undefined so the frontend will not display the comment count.
@Sebastian-Webster Sebastian-Webster added the bug Something isn't working label Oct 10, 2023
@Sebastian-Webster Sebastian-Webster self-assigned this Oct 10, 2023
@Sebastian-Webster Sebastian-Webster linked a pull request Oct 10, 2023 that will close this issue
ImagePost now shows comment count #244
Merged
@Sebastian-Webster Sebastian-Webster added this to the Before Release milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebastian-Webster Sebastian-Webster

Labels
bug Something isn't working
Projects
None yet
Milestone
Before Release
Development

Successfully merging a pull request may close this issue.

ImagePost now shows comment count SquareTable/SocialSquare-App
1 participant
@Sebastian-Webster