Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store notification keys in RefreshTokens instead of User document #142

Closed
Sebastian-Webster opened this issue Sep 16, 2023 · 2 comments · Fixed by #144
Closed

Store notification keys in RefreshTokens instead of User document #142

Sebastian-Webster opened this issue Sep 16, 2023 · 2 comments · Fixed by #144
Assignees
@Sebastian-Webster
Labels
enhancement New feature or request

Comments

@Sebastian-Webster
Copy link
Member

Instead of having the notification keys stored in the user document, they should be stored per device in a RefreshToken document
@Sebastian-Webster Sebastian-Webster added the enhancement New feature or request label Sep 16, 2023
@Sebastian-Webster Sebastian-Webster self-assigned this Sep 16, 2023
@Sebastian-Webster
Copy link
Member Author

Sebastian-Webster commented Sep 16, 2023 •
edited
Loading

APIs that need modifications to get this to work:

  1. temp/sendnotificationkey - Done in commit bcb1db7

Database schemas that need modifications to get this to work:

  1. RefreshToken - Done

Other files to make changes too:

  1. notificationHandler.js - Done in commit 795abd6

@Sebastian-Webster Sebastian-Webster mentioned this issue Sep 16, 2023
Closed
@Sebastian-Webster
Copy link
Member Author

Changes also need to be made in the frontend repository, and those changes will be tracked here: SquareTable/SocialSquare-App#195

@Sebastian-Webster Sebastian-Webster linked a pull request Sep 16, 2023 that will close this issue
Notification keys are now stored in RefreshToken documents instead of in the User document #144
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebastian-Webster Sebastian-Webster

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Sebastian-Webster