Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Remove --always-copy >=EL7 #77

Open
punkrokk opened this issue Mar 21, 2020 · 2 comments
Open

Remove --always-copy >=EL7 #77

punkrokk opened this issue Mar 21, 2020 · 2 comments
Labels
bug good first issue OS support Support/issues/PRs on a specific OS

Comments

@punkrokk
Copy link
Member

The below two files needs the
virtualenv_opts = --always-copy line either commented out or the value removed.

This needs validation. If StackStorm/st2#4891 is merged, we can assume it's a go.

[actionrunner]
logging = /etc/st2/logging.actionrunner.conf
virtualenv_opts = --always-copy

https://github.com/StackStorm/chef-stackstorm/blob/2aa543bbb19df1c176299aea22828d7a6e6e41a6/spec/recipes/config_spec.rb#L30:L32

@arm4b
Copy link
Member

arm4b commented Mar 22, 2020

A little bit more context.

Per StackStorm/st2#4891 note that --always-copy flag should be removed for both EL7 and EL8 as it breaks virtualenv for pack install in these systems. However should exist for all other systems: currently EL6, U14, U16, U18.

This virtualenv_opts adjustment is automatically done by the packaging, however applying and templating custom st2.conf as it's done in chef-stackstorm breaks it.

cc @nmaludy Please check if there is a similar issue with the Puppet module or whether st2.conf templating happens there too.

@nmaludy
Copy link
Member

nmaludy commented Mar 23, 2020

@armab Doesn't appear to be an issue in the Puppet module. In Puppet we use the ini_setting resource and edit individual pieces instead of templating the whole file (for now).

@blag blag added the OS support Support/issues/PRs on a specific OS label Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug good first issue OS support Support/issues/PRs on a specific OS
Projects
None yet
Development

No branches or pull requests

4 participants