From 1d8ffbf3a411120918e9f5fd7d76a61d4b6f400d Mon Sep 17 00:00:00 2001 From: Jacob Zufelt Date: Fri, 16 Feb 2024 12:25:59 -0700 Subject: [PATCH 1/3] Add missing policy and fix function --- templates/jobs.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/templates/jobs.yaml b/templates/jobs.yaml index 3e77c179..4b0b59fe 100644 --- a/templates/jobs.yaml +++ b/templates/jobs.yaml @@ -540,7 +540,7 @@ spec: and then delete this st2canary pod manually. INTRO - function __handle_error__(){ + function __handle_error__ { cat <<- 'FAIL' ERROR: One or more volumes in st2.packs.volumes (from helm values) does not meet StackStorm's shared volumes requirements! @@ -577,6 +577,7 @@ spec: {{- toYaml $.Values.st2.packs.volumes.configs | nindent 10 }} {{- end }} # st2canary job does not support extra_volumes. Let us know if you need this. + restartPolicy: OnFailure {{- if $.Values.dnsPolicy }} dnsPolicy: {{ $.Values.dnsPolicy }} {{- end }} From 944ce2d608920b915c5744ee813568d92a724ecc Mon Sep 17 00:00:00 2001 From: Jacob Zufelt Date: Fri, 16 Feb 2024 12:56:53 -0700 Subject: [PATCH 2/3] Change policy --- templates/jobs.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/jobs.yaml b/templates/jobs.yaml index 4b0b59fe..21705bcc 100644 --- a/templates/jobs.yaml +++ b/templates/jobs.yaml @@ -577,7 +577,7 @@ spec: {{- toYaml $.Values.st2.packs.volumes.configs | nindent 10 }} {{- end }} # st2canary job does not support extra_volumes. Let us know if you need this. - restartPolicy: OnFailure + restartPolicy: Never {{- if $.Values.dnsPolicy }} dnsPolicy: {{ $.Values.dnsPolicy }} {{- end }} From db7adf7179929c26e1657c2646c335431d12d94a Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Fri, 16 Feb 2024 14:00:14 -0600 Subject: [PATCH 3/3] Add changelog entry --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b03e304c..ad29d134 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Changelog +## Development +* Fix syntax with ensure-packs-volumes-are-writable job (#403) (by @skiedude) + ## v1.0.0 * Bump to latest CircleCI orb versions (kubernetes@1.3.1 and helm@3.0.0 by @ZoeLeah) * Remove unsupported k8s Versions (1.24.x and 1.25.x by @ZoeLeah)