Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] CRD support in sr-operator Helm chart #448

Open
mingmxu opened this issue Feb 15, 2024 · 1 comment
Open

[enhancement] CRD support in sr-operator Helm chart #448

mingmxu opened this issue Feb 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mingmxu
Copy link
Contributor

mingmxu commented Feb 15, 2024

Describe the current behavior

StarRocksCluster CRD is saved in a separated folder as shown in here.
In this structure, there's no upgrade support on CRD, since Helm by default ignore the CRD folder simply when the CRD is there already. As a result it can be handled in a delete-recreate pattern only. Implicitly there's always downtime of SR clusters since they are deleted when the old CRD is deleted, plus manually re-deploy the SR clusters after the new CRD is created.

Describe the enhancement

Moving CRD into the regular templates folder, or moving it to another sub-chard as dependency, CRD upgrade is treated as other resources.

Additional context

SR operator/CRD is the mainstream pattern which has a global CRD and a single global controller for the CRD. It's the perfectly legitimate way of packaging as described here.

Ps, CRD versioning is another topic in #445.

cc @dengliu @yandongxiao @kevincai

@mingmxu mingmxu added the enhancement New feature or request label Feb 15, 2024
@yandongxiao
Copy link
Collaborator

I think you are right. we can move the CRD yaml to templates directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants