Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

st not set as historical ligature? #61

Closed
dwhieb opened this issue Aug 15, 2024 · 8 comments
Closed

st not set as historical ligature? #61

dwhieb opened this issue Aug 15, 2024 · 8 comments

Comments

@dwhieb
Copy link

dwhieb commented Aug 15, 2024

I'm using Common Serif as a web font, and by default it displays st with the historical ligature, like so:

image

(That image was captured from the Common Serif demo at LocalFonts.eu.)

Common Serif seems to be treating st as a common ligature rather than a historical ligature. Because of this, the only way I can turn off the st ligature is by turning off all ligatures, which is undesirable.

Note that the similar ct ligature does seem to be treated as a historical ligature. It is only activated when I opt into historical ligatures for the font, which is the expected behavior.
@dwhieb dwhieb changed the title st not set as historical ligature? st not set as historical ligature? Aug 15, 2024
@StefanPeev
Copy link
Owner

StefanPeev commented Aug 15, 2024 •
edited
Loading

@dwhieb Please, give me a link to your website.

@dwhieb
Copy link
Author

dwhieb commented Aug 16, 2024

https://nisinoon.net/grammar

I've currently disabled common ligatures, so the st ligature isn't showing. But if you inspect the <body> tag in your browser and disable the font-variant-ligatures rule, you'll see the st ligature appear.

Alternatively, you can see the problem by taking the following steps:

  1. Go to the Common Serif page on LocalFonts.eu.
  2. Scroll down to the area where you can input sample text and type st ct in the box.
  3. You should see the ligature on st but not ct. If you then change the OpenType settings so that Standard Ligatures are not included, the st ligature disappears. Alternatively, if you choose Historical Ligatures, the ligatures appear on both st and ct.

@StefanPeev
Copy link
Owner

@dwhieb Thank you, Daniel. What will you say if I place /s /t in DLIG feature. I think that LIGA feature must look like this.

`feature liga {
sub f f i by f_f_i;
sub f f l by f_f_l;
sub f f by f_f;
sub f i by fi;
sub f l by fl;

} liga;`

In HLIG ligature I'll place only the long s ligatures, everything else will be in DLIG ligatures.

@dwhieb
Copy link
Author

dwhieb commented Aug 16, 2024

I think that makes sense. It seems like the st ligature should be in the same category as the ct ligature, wherever that is.

It might be worth noting that the Libertinus font placed both ct and st in the HLIG category though:

https://github.com/alerque/libertinus/blob/master/sources/features/dhlig.fea

@StefanPeev
Copy link
Owner

StefanPeev commented Aug 16, 2024 •
edited
Loading

@dwhieb I do not see reason st and ct ligatures to be placed in HLIG - it is better if they are part of DLIG.

@dwhieb
Copy link
Author

dwhieb commented Aug 16, 2024

That's fine by me! I defer to your expertise.

@StefanPeev
Copy link
Owner

@dwhieb st and ct ligatures are in DLIG feature in v.1.038.

@dwhieb
Copy link
Author

dwhieb commented Dec 7, 2024

Awesome! That's a huge help! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dwhieb @StefanPeev