Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display planet nomenclature information #3455

Closed
gzotti opened this issue Oct 10, 2023 · 5 comments · Fixed by #3457
Closed

Display planet nomenclature information #3455

gzotti opened this issue Oct 10, 2023 · 5 comments · Fixed by #3457
Assignees
Labels
description Improvements or additions to description of scenery, landscape or skyculture… feature Entirely new feature
Milestone

Comments

@gzotti
Copy link
Member

gzotti commented Oct 10, 2023

Stellarium can display named features on planet surfaces (NomenclatureItem). The names can be translated, which is necessary only for few languages. Translators see the explanation who the commemorated person (or terrestrial landscape, mythical river, ...) was. Users don't see that.

Describe the solution you'd like
Add an optional line to the NomenclatureItem InfoString that provides translatable information about the feature name. This has about the same add-on value as discoverer names for DSO.

Describe alternatives you've considered
None so far. (Looking up in Transifex or the pot file is no real solution.)

Additional context

The current format is (SSO); information . This format can be translated as-is. For display, the part (SSO); can be omitted. However, how would RtoL languages (e.g. arab) have to be formatted?

@gzotti gzotti added feature Entirely new feature description Improvements or additions to description of scenery, landscape or skyculture… labels Oct 10, 2023
@github-actions
Copy link

Hello @gzotti!

Thank you for suggesting this feature.

@alex-w
Copy link
Member

alex-w commented Oct 10, 2023

I can add this feature by half hour, but this is bad idea, because it will add over 15000 new translatable strings

@gzotti
Copy link
Member Author

gzotti commented Oct 10, 2023

I know the number is huge, and it may be a bad idea to just simply add the strings for all. However, it is IMHO interesting side info.
Maybe we should think of add-on translation packages for in-program installation? (Like downloadable star catalogs. Also the extra DSO catalog could be transformed into an in-program download.)
I think exactly the translations for the planet nomenclature offers itself as add-on download. If not installed, only the English names would be shown. This may be enough for most users. Those interested in translated names and/or their explanation could install the translated package. And probably nomenclatureItem "name translation" can be limited to languages "where necessary" (e.g. where it includes transliteration). Many European languages likely just copy all the ("internationally approved") names 1:1.

@alex-w alex-w self-assigned this Oct 10, 2023
@alex-w alex-w linked a pull request Oct 11, 2023 that will close this issue
14 tasks
@gzotti gzotti added this to the 23.4 milestone Oct 11, 2023
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 23, 2023
@github-actions
Copy link

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023
Copy link

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
description Improvements or additions to description of scenery, landscape or skyculture… feature Entirely new feature
Development

Successfully merging a pull request may close this issue.

2 participants