Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-zoom out behavior #3553

Open
alex-w opened this issue Dec 14, 2023 · 7 comments · May be fixed by #4018
Open

Auto-zoom out behavior #3553

alex-w opened this issue Dec 14, 2023 · 7 comments · May be fixed by #4018
Assignees
Labels
bug Something likely wrong in the code subsystem: gui The issue is related to GUI subsystem of planetarium...
Milestone

Comments

@alex-w
Copy link
Member

alex-w commented Dec 14, 2023

One the MacBook Pro M3, with Stellarium v22.3(v1.0) - the planet auto-zoom feature does not appear working correctly.

After selecting the planet, the forward-slash key zooms into the planet.

But when selecting the backslash key - the initial auto-zoom does not "return to the initial FOV and direction of view" (as it says in the manual)

It moves to a different FOV (the horizon is curved and 90-deg wide, not 180-deg); with the forward position of view no longer South, but the direction of the location of the planet.

I've checked the config settings, and they're all the same as my old v19.3.

So I'm not sure if there's something I need to change, or if this is a bug?

Thank you - yet the Auto-direction at zoom out does not solve the problem.

Here is the zoom out before selecting Auto-direction at zoom out

Here is the zoom out after selecting Auto-direction at zoom out

Here is the correct zoom out behaviour, from v19.3

Check-box

Originally posted by @ImmersiveTheatres in #3535 (comment)

@alex-w
Copy link
Member Author

alex-w commented Dec 14, 2023

Probably the issue #2867 related to the "new" behavior too

@alex-w alex-w added the bug Something likely wrong in the code label Dec 14, 2023
@alex-w alex-w changed the title Auto-zoom out behaviour Auto-zoom out behavior Dec 14, 2023
@alex-w
Copy link
Member Author

alex-w commented Dec 14, 2023

@gzotti can be this issue related to your modifications in StelMovementMgr class?

@gzotti
Copy link
Member

gzotti commented Dec 14, 2023

Maybe. I did some necessary relevant changes in August/September 2022. Version 0.22.1 should therefore not show it (but maybe some other issue). This class is a serious nightmare!

@gzotti gzotti self-assigned this Dec 26, 2023
@gzotti gzotti added this to the 24.1 milestone Dec 26, 2023
@alex-w alex-w modified the milestones: 24.1, 24.2 Mar 21, 2024
@gzotti gzotti modified the milestones: 24.2, 24.3 Jun 20, 2024
@gzotti
Copy link
Member

gzotti commented Sep 17, 2024

Given that I don't remember ever having used this function in the past 12 years (probably because the backslash key never worked on German keyboards?): Should the last orientation/FOV combination be remembered at onset of the forward-slash zoom-in and restored at end of the backslash operation? Or what exactly is the operation? Also the translation is insufficient... What should happen if this "zoom out" is pressed again?

@ImmersiveTheatres
Copy link

Forward slash:

  • first press = zoom in
  • second press = zoom in some more

Backward slash:

  • first press = zoom out
  • second press = zoom out some more (back to night sky view, same orientation as before)

This is how I've always used it, and it's great for teaching!

@gzotti
Copy link
Member

gzotti commented Sep 17, 2024

Is that presumably "center and zoom"?
And if you zoom in, and then do something else? When will a state of "zoomlevel1" or "zoomlevel2" be forgotten? When you unselect/select something else? When you move the scene (mouse drag or keyboard) and press again? Just re-center to zoomlevel1, or further on to zoomlevel2?

I can see the application in a teaching environment, just am unfamiliar with these operations which is why they got lost for the sake of other improvements. As said, this part is really super convoluted.

@ImmersiveTheatres
Copy link

I think most teachers will use this functionality in a simple way like I do ie. zoom in, discuss, zoom in more, discuss, zoom out, zoom out more.

I don't move the mouse / scene or do anything else while zoomed in.

Occasionally at zoomlevel1 if I'm at say Jupiter, I zoom in to one or two of the moons. Then zooming out we're back at Jupiter (re-centred).

It works best if centred / re-centred is the default for zooming / un-zooming.

@alex-w alex-w mentioned this issue Sep 19, 2024
56 tasks
@gzotti gzotti modified the milestones: 24.3, 24.4 Sep 19, 2024
@alex-w alex-w added the subsystem: gui The issue is related to GUI subsystem of planetarium... label Oct 13, 2024
@alex-w alex-w modified the milestones: 24.4, 25.1, 25.2 Dec 21, 2024
@gzotti gzotti linked a pull request Dec 23, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code subsystem: gui The issue is related to GUI subsystem of planetarium...
Development

Successfully merging a pull request may close this issue.

3 participants