Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Router 4 #14

Open
kanlanc opened this issue Jun 11, 2018 · 3 comments
Open

React Router 4 #14

kanlanc opened this issue Jun 11, 2018 · 3 comments

Comments

@kanlanc
Copy link

kanlanc commented Jun 11, 2018

Love your courses.
Just that in this one, react router 3 was used. I modified the code to 4 and if it is fine will open a PR to merge it with branch with comments explaining the code.
@benoitboucart
Copy link

benoitboucart commented Aug 24, 2018 •
edited
Loading

@highskillzz could you share the update please?
My version works but when I refresh (for example http://localhost:4000/song/new), I got a not found error (due to missing # is in URL & webpackMiddleware).

@kanlanc
Copy link
Author

kanlanc commented Sep 1, 2018

@benoitboucart sorry for the late reply but here is the update
https://github.com/highskillzz/Lyrical-application-using-graphql

@reeversedev
Copy link

Been looking for this issue. Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benoitboucart @kanlanc @reeversedev