Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build scripts and restore ability to publish to a private repository #115

Merged
merged 7 commits into from
Dec 18, 2023

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Dec 14, 2023

I've just cleaned up the build sources, and restored the ability to use a private repository to publish to.
I need the private one for testing new features/refactorings outside of my machine.

This should be merged before #114.

@lppedd lppedd marked this pull request as draft December 14, 2023 14:10
@lppedd
Copy link
Contributor Author

lppedd commented Dec 14, 2023

Converted to draft to re-verify a couple things. Should be ready in 30 minutes.

@lppedd
Copy link
Contributor Author

lppedd commented Dec 14, 2023

Not sure what's going on but my project doesn't compile correctly anymore with artifacts published to my private repo.
Need to investigate.

@lppedd
Copy link
Contributor Author

lppedd commented Dec 14, 2023

As discussed the issue is in the way Gradle's antlr plugin fiddles with source sets when it is applied.
To keep it short, that plugin makes a mess when Kotlin Multiplatform is involved, but works fine with projects targeting Java only.

We are forced to go back and use a custom plugin.

@lppedd lppedd marked this pull request as ready for review December 14, 2023 18:18
@lppedd lppedd mentioned this pull request Dec 15, 2023
2 tasks
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
booleanProperty("target.is.js")


fun PublishingExtension.addSonatypeRepository(project: Project) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this configuration, where do we setup the credentials for publishing to sonatype?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I removed that one because it was unused, couldn't find any reference to it.

Copy link
Member

@ftomassetti ftomassetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comment

@ftomassetti ftomassetti merged commit fe502bb into Strumenta:master Dec 18, 2023
4 checks passed
@lppedd lppedd deleted the build/cleanup branch December 18, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants