-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup build scripts and restore ability to publish to a private repository #115
Conversation
Converted to draft to re-verify a couple things. Should be ready in 30 minutes. |
Not sure what's going on but my project doesn't compile correctly anymore with artifacts published to my private repo. |
As discussed the issue is in the way Gradle's We are forced to go back and use a custom plugin. |
...rc/main/kotlin/com/strumenta/kotlinmultiplatform/gradle/ext/MavenPublishBaseExtension.ext.kt
Show resolved
Hide resolved
buildSrc/src/main/kotlin/com/strumenta/kotlinmultiplatform/gradle/ext/Project.ext.kt
Show resolved
Hide resolved
booleanProperty("target.is.js") | ||
|
||
|
||
fun PublishingExtension.addSonatypeRepository(project: Project) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove this configuration, where do we setup the credentials for publishing to sonatype?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I removed that one because it was unused, couldn't find any reference to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comment
I've just cleaned up the build sources, and restored the ability to use a private repository to publish to.
I need the private one for testing new features/refactorings outside of my machine.
This should be merged before #114.