Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

73 plugin application broken if project version is different than the language server library version #74

Merged
merged 3 commits into from
Mar 11, 2024
Merged

73 plugin application broken if project version is different than the language server library version #74

merged 3 commits into from
Mar 11, 2024

Conversation

loradd
Copy link
Contributor

@loradd loradd commented Mar 11, 2024

Fixes #73

@loradd loradd added the bug Something isn't working label Mar 11, 2024
@loradd loradd requested a review from ftomassetti March 11, 2024 09:53
@loradd loradd self-assigned this Mar 11, 2024
@loradd loradd linked an issue Mar 11, 2024 that may be closed by this pull request
Plugin application broken if project version is different than the language server library version #73
Closed
martin-azpillaga
martin-azpillaga approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@martin-azpillaga martin-azpillaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions!

Regarding formatting changes, I am curious why these were not present before.
I hope that the formatting is standardized now and won't cause big changes in the future.

gradle.properties Show resolved Hide resolved
library/build.gradle.kts Outdated Show resolved Hide resolved
testing/build.gradle.kts Outdated Show resolved Hide resolved
@loradd
build: adds version catalogs to centralize versions (could be migrate…
a22b785 
…d to .toml in the future)

Signed-off-by: Lorenzo Addazi <[email protected]>
@loradd loradd merged commit de6fff9 into main Mar 11, 2024
1 check passed
@loradd loradd deleted the 73-plugin-application-broken-if-project-version-is-different-than-the-language-server-library-version branch March 11, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-azpillaga martin-azpillaga martin-azpillaga approved these changes

@ftomassetti ftomassetti Awaiting requested review from ftomassetti

Assignees

@loradd loradd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin application broken if project version is different than the language server library version
2 participants
@loradd @martin-azpillaga