Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep browser extension connection status up to date #33

Closed
l0f3n opened this issue Jan 14, 2025 · 1 comment · Fixed by #44
Closed

Keep browser extension connection status up to date #33

l0f3n opened this issue Jan 14, 2025 · 1 comment · Fixed by #44
Assignees
Milestone

Comments

@l0f3n
Copy link
Contributor

l0f3n commented Jan 14, 2025

Right now when a person joins the lobby, they will always be there even if they leave or gets disconnected. We could remedy this by continuously sending pings from the browser extension, and if the server has not seen a ping when it excepts it can send a player leave message to the client. This could also be sent in the case that a player leaves manually using the button.

@l0f3n
Copy link
Contributor Author

l0f3n commented Jan 15, 2025

We dont really want to remove such players from the graph, so one thing we could is mark them as inactive when they disconnect and kick all inactive players when the game starts. That way we never actually discard any interesting information about them. I think that would be a decent solution.

@l0f3n l0f3n self-assigned this Feb 2, 2025
@l0f3n l0f3n closed this as completed in #44 Feb 6, 2025
@l0f3n l0f3n added this to the v1.1.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant