Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query variable in sosl and soql nodes has wrong scope #13

Closed
dwindibank opened this issue Feb 23, 2018 · 4 comments
Closed

query variable in sosl and soql nodes has wrong scope #13

dwindibank opened this issue Feb 23, 2018 · 4 comments
Labels

Comments

@dwindibank
Copy link

dwindibank commented Feb 23, 2018

The query variable (var query ='') in the soql and sosl nodes have the wrong scope. This results in the variable being reused ... i.e. multiple message's overwriting the value of the variable (via each messages' msg.query value).

I think this may have been the root cause on jeffdonthemic#8 and jeffdonthemic#2

@dwindibank
Copy link
Author

I created a pull request for this: #14

@Stwissel Stwissel added the bug label Feb 26, 2018
@Stwissel
Copy link
Owner

Thx for that. Slipped my debugging. Merged in

@Stwissel
Copy link
Owner

Btw.: need to bump version in package.json, so build process can automatically publish it

@dwindibank
Copy link
Author

Awesome. Thanks!

I'll remember about the version bump for next time I submit a pull request. Thanks, again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants