Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instances capped to zero duration get stuck in state #91

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Nov 1, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bug

  • What is the current behavior? (You can also link to an open issue here)

Sometimes objects can be given a start and end time of the same point in time, and appear in the state as a start with no end

  • Other information:

related to #79 ?

@Julusian Julusian changed the title chore: test for object in group producing 0 duration object at the end fix: instances capped to zero duration get stuck in state Nov 1, 2022
@Julusian Julusian marked this pull request as ready for review November 1, 2022 14:29
@Julusian Julusian requested a review from nytamin November 1, 2022 14:29
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 97.36% // Head: 97.37% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a6a41d9) compared to base (2feb115).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a6a41d9 differs from pull request most recent head 56e3879. Consider uploading reports for the commit 56e3879 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   97.36%   97.37%           
=======================================
  Files          12       12           
  Lines        1482     1483    +1     
  Branches      552      553    +1     
=======================================
+ Hits         1443     1444    +1     
  Misses         39       39           
Impacted Files Coverage Δ
src/resolver/state.ts 99.10% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@nytamin nytamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting edge case! The fix looks pretty good!

@Julusian Julusian merged commit ec4ecd4 into master Nov 1, 2022
@Julusian Julusian deleted the bug/object-with-no-duration branch November 1, 2022 14:52
@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants