You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Connection errors should not be handled.
I think this is something the user of this library should handle.
We could bubble up an error but everything else seems wrong since it could cause errors if we change something on the shared connection.
Channel error handling an reestablishing those could be worth it.
Maybe even only use one instead of two channels. (Publish and Subscribe use one each)
But the combining of those channels should be discussed and well researched.
Per https://github.com/Surnet/graphql-amqp-subscriptions/pull/13/files#r422921589 , we should handle channel errors by attempting to re-establish them when possible. https://github.com/guidesmiths/rascal is a good example to go off of.
The text was updated successfully, but these errors were encountered: