Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PubSubAsyncIterator pushQueue protected #51

Open
bisztray opened this issue Feb 9, 2024 · 1 comment
Open

Make PubSubAsyncIterator pushQueue protected #51

bisztray opened this issue Feb 9, 2024 · 1 comment

Comments

@bisztray
Copy link

bisztray commented Feb 9, 2024

This is more like a very simple feature request then an issue. I'd like to implement a mechanism in the PubSubAsyncIterator to limit the pushQueue size. I'd like to subclass PubSubAsyncIterator but I'd need the pushQueue() function and the pushQueue array to be protected not private.
Is there any reason they are private? If not could you change these, or should I send a pull request?

@chdanielmueller
Copy link
Member

It is an implementation of this: https://github.com/apollographql/graphql-subscriptions/blob/master/src/pubsub-async-iterable-iterator.ts

There it is made private.
I do not know if there are reasons for this, I just used the generic sample as provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants