Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Manga with long lists of authors fail with "Could not load manga" #1204

Closed
ceridwen opened this issue Dec 16, 2024 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@ceridwen
Copy link

Device information

  • Suwayomi-Server version: v1.1.1
  • Server Operating System: Ubuntu 22.04
  • Server Desktop Environment: Gnome 42.9
  • Server JVM version: OpenJDK 64-Bit Server VM (build 11.0.25+9-post-Ubuntu-1ubuntu122.04, mixed mode, sharing)
  • Client Operating System: same
  • Client Web Browser: Firefox 133.0

Steps to reproduce

  1. Try to load a manga with an author list longer than 512 characters (many anthologies for instance).

Expected behavior

The manga loads normally.

Actual behavior

See an error like the author list followed by "can't be stored to database column because exceeds length 512."

@ceridwen ceridwen added the bug Something isn't working label Dec 16, 2024
@Robonau
Copy link
Contributor

Robonau commented Dec 16, 2024

description had a similar issue before #54
was fixed by truncating.

@Nitrousoxide
Copy link

I see there was already an issue now after I opened mine, so I'm closing mine and will give a more detailed run down of how to replicate it.
Device information

Suwayomi-Server version: v1.1.1
Server Operating System: Docker image (host server is running on Bookworm however)
Server Desktop Environment: N/A
Server JVM version: Whatever it is for ghcr.io/suwayomi/tachidesk:stable
Client Operating System: Haven't checked the dockerfile, but whatever the base distro is for ghcr.io/suwayomi/tachidesk:stable
Client Web Browser: Firefox 11.21.0

Steps to reproduce

Setup extension sources
Install mangadex source
Search for manga with very long series or artist name (example: [Link](https://mangadex.org/title/027df837-7a15-4893-9dc3-e2ae11b94717/onii-chan-is-done-for-official-anthology-comic))
Get error:

image

Expected behavior

Excessive name lengths should be truncated or otherwise handled gracefully rather than erroring out.
Actual behavior

App throws error and is unable to load series chapter list

@schroda
Copy link
Collaborator

schroda commented Dec 21, 2024

this has already been fixed (0adbea3)

@schroda schroda closed this as completed Dec 21, 2024
@Nitrousoxide
Copy link

Ah, so the fix is in the repo, but not the 1.1.1 build then? I don't think a new release has been published since that commit.

I guess we'll just have to wait for the next release.

@Syer10
Copy link
Collaborator

Syer10 commented Dec 21, 2024

Its available in the Preview version which you can find in the ReadMe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants