Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GraphQL multipart request - incorrect implementation #692

Closed
schroda opened this issue Sep 27, 2023 · 0 comments · Fixed by #694
Closed

[Bug] GraphQL multipart request - incorrect implementation #692

schroda opened this issue Sep 27, 2023 · 0 comments · Fixed by #694
Labels
bug Something isn't working

Comments

@schroda
Copy link
Collaborator

schroda commented Sep 27, 2023

Specification: https://github.com/jaydenseric/graphql-multipart-request-spec

Problem

  1. Expecting specific map keys
    Currently the server expects the map keys to start with 0.
    According to the specification, the client can set the keys to be anything and the server should be able to handle it.
    Due to this, libraries like https://github.com/jaydenseric/apollo-upload-client, are currently unusable.
    E.g. the mentioned library starts its keys with 1, thus, sending requests that the server can't handle.

  2. Form parameter "operation"
    The server checks for the form parameter operation, while it is operations in the specification

Solution
Update current implementation to follow the specification.

@schroda schroda added the bug Something isn't working label Sep 27, 2023
@Syer10 Syer10 mentioned this issue Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant