Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Timeout on Tachiyomi chapters listing #733

Closed
alexandrejournet opened this issue Oct 26, 2023 · 8 comments
Closed

[Bug] Timeout on Tachiyomi chapters listing #733

alexandrejournet opened this issue Oct 26, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@alexandrejournet
Copy link
Contributor

Device information

  • Tachidesk version: docker-tachidesk stable v0.7.0
  • Server Operating System: Debian
  • Server Desktop Environment: N/A
  • Server JVM version: default
  • Client Operating System: Debian
  • Client Web Browser: Latest chrome

Steps to reproduce

  1. On Tachiyomi, when the chaptersList is huge (1300+), the onlineFetch takes to much time and I got a timeout.
  2. On Postman it works, so I can put screenshots.

Expected behavior

We should get the list of chapters.

Actual behavior

Got a Socket Timeout Exception

Other details

image

@alexandrejournet alexandrejournet added the bug Something isn't working label Oct 26, 2023
@Syer10
Copy link
Collaborator

Syer10 commented Oct 26, 2023

onlineFetch means its fetching chapters from the source, if the source takes too long to give us the chapters it can timeout, what do you suggest we do? I feel like the timeout is a good way to handle this.

@alexandrejournet
Copy link
Contributor Author

It's taking way too much time in my opinion, i cant fetch them in tachiyomi even with a Timeout of 2 minutes... :/

I will try to fix it ^^

@Syer10
Copy link
Collaborator

Syer10 commented Oct 26, 2023

Tachidesk is waiting on the source to return chapters, it sounds like you are using a slow source, have you tried others?

@alexandrejournet
Copy link
Contributor Author

alexandrejournet commented Oct 26, 2023

It's working for my others mangas, it's only this one with 1300+ files which takes too much time, and I think I'm not the only one having this timeout problem on a huge library :/

@alexandrejournet
Copy link
Contributor Author

alexandrejournet commented Oct 26, 2023

I'm going to audit the code and check if there's not too many connections to the databases, or too many inserts one by one instead of a list insert, something like this to optimise the request

@Syer10
Copy link
Collaborator

Syer10 commented Oct 26, 2023

Hmm, its possible the chapter sync logic could be inefficient, I forgot about that. If you find a problematic section let us know.

@alexandrejournet
Copy link
Contributor Author

I will ! And I'll try to make a pr

alexandrejournet pushed a commit to alexandrejournet/Tachidesk-Server that referenced this issue Oct 27, 2023
alexandrejournet pushed a commit to alexandrejournet/Tachidesk-Server that referenced this issue Oct 29, 2023
alexandrejournet pushed a commit to alexandrejournet/Tachidesk-Server that referenced this issue Oct 29, 2023
alexandrejournet pushed a commit to alexandrejournet/Tachidesk-Server that referenced this issue Oct 29, 2023
alexandrejournet pushed a commit to alexandrejournet/Tachidesk-Server that referenced this issue Oct 30, 2023
alexandrejournet pushed a commit to alexandrejournet/Tachidesk-Server that referenced this issue Oct 30, 2023
Syer10 pushed a commit that referenced this issue Oct 30, 2023
…s calls) (#737)

* improve(#733): less databases calls on getChapterList with onlineFetch

* improve(#733): fixes (delete with ids), tried batch update but not successfull

* improve(#733): fixes (batch update)

* improve(#733): clean imports

* improve(#733): fixes SChapter to ChapterDataClass,

* improve(#733): re-added recognize chap number

---------

Co-authored-by: Alexandre JOURNET <[email protected]>
@alexandrejournet
Copy link
Contributor Author

@Syer10 This issue can be closed, with the latest preview it worked. With PR #737

alexandrejournet pushed a commit to alexandrejournet/Tachidesk-Server that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants