Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] 删除watchdog,上传配置交由操作员完成 #593

Closed
2 tasks
SAKURA-CAT opened this issue May 30, 2024 · 0 comments · Fixed by #601
Closed
2 tasks

[REQUEST] 删除watchdog,上传配置交由操作员完成 #593

SAKURA-CAT opened this issue May 30, 2024 · 0 comments · Fixed by #601
Assignees
Labels
💪 enhancement New feature or request
Milestone

Comments

@SAKURA-CAT
Copy link
Contributor

SAKURA-CAT commented May 30, 2024

🤩 Features description [Please make everyone to understand it]

#418 中,我们使用了watchdog辅助文件上传。经过一段时间的使用,我们发现这并不合理,具体来看:

  • watchdog会开启两个(以上)线程,负责收集更新事件和处理更新事件,单纯为了文件更改而更新事件这没有必要
  • watchdog对系统要求较高,因为它监听了文件树,来自 [QUESTION] OSError: [Errno 28] inotify watch limit reached #579
  • 可能会出现没监听到事件更改的情况

因此在0.3.x版本中我们打算废除它,但是目前存在一些需解决的问题:


理论上删除了watchdog就能完成mode="cloud-only"的实现

@SAKURA-CAT SAKURA-CAT added the 💪 enhancement New feature or request label May 30, 2024
@SAKURA-CAT SAKURA-CAT added this to the v0.3.x milestone May 30, 2024
@SAKURA-CAT SAKURA-CAT self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant