Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas estimation and displaying them #1714

Open
8 tasks
0xVenky opened this issue Feb 3, 2023 · 0 comments
Open
8 tasks

Gas estimation and displaying them #1714

0xVenky opened this issue Feb 3, 2023 · 0 comments
Assignees

Comments

@0xVenky
Copy link
Member

0xVenky commented Feb 3, 2023

Description
We would like to reintroduce gas estimation in Swapr.

Definition of done

  • Description is created (Task creator)
  • Code is complete (Developer)
  • Scope of test and what was done section is defined in task (Developer)
  • Review passed (Code reviewer)
  • Verified manually (QA)
  • Test cases created/updated if necessary (QA)
  • Change successfully merged
  • Release notes added if needed

Proposal
As a user, I would like to see which dexes / aggregators cost how much gas before I place a swap. The gas costs should be converted to USD and should be added to the total cost for a swap and then sorted based on cheapest to expensive.

Additional context
1inch swaps are found to be cheaper than performing swaps with UniV3, but seems like we show UniV3 has better swap rate than 1inch because we do not calculate the gas Fees into account.

@0xVenky 0xVenky added this to Swapr Feb 3, 2023
@0xVenky 0xVenky moved this to 🧑‍💻 In Progress in Swapr Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🧑‍💻 In Progress
Development

No branches or pull requests

2 participants