-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAN FD support #13
Comments
+1 for CANivore support. |
implemented on my fork (for Mk4 only, for now): https://www.chiefdelphi.com/t/official-sds-mk3-mk4-code/397109/101?u=democat you can specify the canbus as a String parameter to the Helper, or you can try out the new Builder class |
I didn't dig around enough to understand why the configuration objects didn't inherit from a base configuration class and why all the factories use decorators (pulling data from the configuration class) instead of just passing the configuration objects down to each factory. I think this could simplify the code. Instead of having multiple constructors for each motor class, just pass in a single configuration object. |
The way the Falcon and CANcoder libraries are currently implemented, there isn't an easy way to change what CAN network they utilize. Considering 8 falcons and 4 CANcoders already is pretty high CAN bus utilization on the RIO, I am sure more people will be utilizing CAN FD CANivores.
The text was updated successfully, but these errors were encountered: