Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAN FD support #13

Open
WOFsoftware51 opened this issue Mar 2, 2022 · 3 comments
Open

CAN FD support #13

WOFsoftware51 opened this issue Mar 2, 2022 · 3 comments

Comments

@WOFsoftware51
Copy link

The way the Falcon and CANcoder libraries are currently implemented, there isn't an easy way to change what CAN network they utilize. Considering 8 falcons and 4 CANcoders already is pretty high CAN bus utilization on the RIO, I am sure more people will be utilizing CAN FD CANivores.

@randomstring
Copy link

+1 for CANivore support.

@democat3457
Copy link

implemented on my fork (for Mk4 only, for now): https://www.chiefdelphi.com/t/official-sds-mk3-mk4-code/397109/101?u=democat

you can specify the canbus as a String parameter to the Helper, or you can try out the new Builder class

@randomstring
Copy link

I didn't dig around enough to understand why the configuration objects didn't inherit from a base configuration class and why all the factories use decorators (pulling data from the configuration class) instead of just passing the configuration objects down to each factory. I think this could simplify the code. Instead of having multiple constructors for each motor class, just pass in a single configuration object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants