Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Viewed Event not to be sent for commits that were inherited from the original project on forking #1477

Open
2 tasks
jachro opened this issue May 11, 2023 · 0 comments

Comments

@jachro
Copy link
Contributor

jachro commented May 11, 2023

It was observed that sending a Project Viewed Event for commits inherited from the parent project while forking is in most cases (if not all) not a good idea. The reason is that they get accounted for on behalf of the author of the commits (the parent project committer) and as a result, it will cause the fork project to be listed as a recently viewed project for the author. In the general case, this is not true as the author could not even know someone forked his project and for sure it might be the project he recently viewed.

Acceptance criteria:

  • Perhaps, we should check the push event author and skip sending an event if the push event author is not a member of the project;
  • It's also worth checking if GL can even provide us with a push event for the commits inherited from the parent project. If not, we should simply skip sending the event in case there's no push event for a commit.
@jachro jachro converted this from a draft issue May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

1 participant