Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten the data structure in the search graphs #1666

Closed
13 tasks done
jachro opened this issue Aug 17, 2023 · 0 comments · Fixed by #1757, #1758, #1761, #1762 or #1775
Closed
13 tasks done

Flatten the data structure in the search graphs #1666

jachro opened this issue Aug 17, 2023 · 0 comments · Fixed by #1757, #1758, #1761, #1762 or #1775

Comments

@jachro
Copy link
Contributor

jachro commented Aug 17, 2023

Learnt from the exercise on the project-auth graph and the flat structure which gives pretty amazing perf improvements, it would be good to apply the same pattern to both Search graphs.

Acceptance criteria:

  • flatten the data structure on both Datasets and Projects graphs
  • adapt the encoding rules for both of them
  • create a TS migration that puts the data into the new structure (leaving the old structure untouched) - release
  • adapt the queries behind:
    • the Cross Entity Search
    • Recently Viewed Entities
    • Authorizers (no changes needed)
  • Remove things that are not used anymore
    • create a TS migration that removes the old unused parts from the graphs - or leave things as they are in the TS hoping they will be slowly disappearing once we stop encoding the non-concatenated properties
      • on Project: schema:keywords, schema:image
      • on DS: schema:keywords, schema:image
    • make sure the queries are cleaned-up (e.g. DatasetInfoDeleteQuery)
    • make sure the ontologies are updated
    • make sure the renku:datasetProjectLink property (and entity) does stay
@jachro jachro converted this from a draft issue Aug 17, 2023
@jachro jachro moved this from Ready to In Progress in KG's kanban Oct 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in KG's kanban Oct 19, 2023
@jachro jachro reopened this Oct 19, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in KG's kanban Oct 19, 2023
@jachro jachro linked a pull request Oct 19, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in KG's kanban Oct 19, 2023
@jachro jachro reopened this Oct 19, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in KG's kanban Oct 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in KG's kanban Oct 31, 2023
@jachro jachro reopened this Oct 31, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in KG's kanban Oct 31, 2023
@jachro jachro moved this from In Progress to Ready in KG's kanban Oct 31, 2023
@jachro jachro moved this from Ready to In Progress in KG's kanban Nov 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in KG's kanban Nov 6, 2023
@jachro jachro removed this from KG's kanban Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment