Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker doesn't close after selecting date #131

Open
1 task done
tyler-dane opened this issue Sep 21, 2024 · 0 comments
Open
1 task done

Date Picker doesn't close after selecting date #131

tyler-dane opened this issue Sep 21, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tyler-dane
Copy link
Contributor

tyler-dane commented Sep 21, 2024

Prerequisites

  • Using an up-to-date main branch

Expected Behavior

After selecting a date from the datepicker, the date picker should close and the selected date should appear in the date field

Current Behavior

After selecting a date from the datepicker, the date picker flashes and stays open

Steps to Reproduce

  1. Click all-day row, which triggers event form to render

  2. Click start or end date, which triggers date picker to render

  3. Select a date from the datepicker

Possible Solution (Not obligatory)

I assume this is because we're re-rendering the form unnecessarily. Refactor the form/datepicker so that it doesn't need to rerender after changing the date

Context

@tyler-dane tyler-dane added the bug Something isn't working label Sep 21, 2024
@tyler-dane tyler-dane changed the title Selecting Date Doesn't Close Datepicker (All-day Events) Selecting Date Doesn't Close Date Picker Sep 21, 2024
@tyler-dane tyler-dane changed the title Selecting Date Doesn't Close Date Picker Date Picker Doesn't Close After Selecting Date Sep 21, 2024
@tyler-dane tyler-dane changed the title Date Picker Doesn't Close After Selecting Date Date Picker doesn't close after selecting date Sep 22, 2024
@tyler-dane tyler-dane added the good first issue Good for newcomers label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

No branches or pull requests

1 participant