-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event is being dragged instead of clicked #150
Comments
Hey @tyler-dane 👋, can I work on this one? |
You bet! |
Hey @tyler-dane, sorry for bothering you, I want to know if this is the issue because when I use other browsers, like MS Edge, Firefox, Chrome or Brave, I don't get this issue. But, when I use my main browser, Arc, I get this: Screen.Recording.2024-10-19.152035.mp4Maybe is this one (recorded in Chrome). As you can see, when slightly moving the mouse the event does shift. Screen.Recording.2024-10-19.152937.mp4You can add a screen recording to understand better the issue. Screen.Recording.2024-10-19.153434.mp4Thanks for your patience. |
Hey @DiegoMutre - no need to apologize! The behavior is kinda confusing, and the fix isn't super clear and might not be straightforward. See this video to see the buggy behavior. Notice how after a simple click during a mouse move the event is being registered as a 'drag' event instead of a 'click', which results in the event moving position on the grid. The bug is more apparent when the mouse move is downwards, due to how the draft event is using an position offset (which is another behavior that is not ideal). The bug behavior should be consistent across browsers. I'm guessing it didn't appear on those other browsers because of how you were clicking and moving the mouse. If you click slowly while the mouse is in the same spot it doesn't happen. BugDemo.mov |
Prerequisites
Expected Behavior
Given that a user clicks an event,
while also (accidentally) slightly moves mouse,
then the change is registered as click
and not a drag.
Current Behavior
The above scenario is treated alike a drag, which results in the event shifting slightly before the form is opened
Steps to Reproduce
While slightly moving your mouse, click an event
Notice: the event is dragged instead of staying in place
Possible Solution (Not obligatory)
Since much of the event drafting logic is built on the
mouseDown
,mouseUp
, andonClick
event handlers, we gotta be careful that whatever solution we find to this problem doesn't create even more downstream issues.As a result, a POC or diagram that highlights the proposed solution would be a good place to start before diving into creating a PR
Context
This decreasing UX by forcing users to be very strict about how they click events. After this happens a few times, users lose confidence in Compass's ability to help them accomplish their tasks easily.
The text was updated successfully, but these errors were encountered: