From 07bac4081394fe8b24d2a77d76574669be6fbdd5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Fr=C3=A9mont?= <lc.fremont@gmail.com>
Date: Fri, 21 Jun 2024 09:00:44 +0200
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
---
 docs/twig-extra/getting-started.md                         | 2 +-
 src/TwigExtra/config/services.php                          | 2 +-
 src/TwigExtra/src/Twig/Extension/SortByExtension.php       | 6 ++----
 .../src/Twig/Extension/TestFormAttributeExtension.php      | 7 ++-----
 .../src/Twig/Extension/TestHtmlAttributeExtension.php      | 4 +---
 .../tests/Unit/Twig/Extension/SortByExtensionTest.php      | 2 +-
 6 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/docs/twig-extra/getting-started.md b/docs/twig-extra/getting-started.md
index c4dcb0b6..70ce7a0f 100644
--- a/docs/twig-extra/getting-started.md
+++ b/docs/twig-extra/getting-started.md
@@ -81,7 +81,7 @@ This is slightly the same behaviour as `sylius_test_html_attribute` Twig functio
 ```
 
 ```html
-<!-- The real results depend on your form theme. -->
+<!-- Actual html output bellow depends on your form theme -->
 <label for="book_title">Title</label>
 <input 
         type="text" 
diff --git a/src/TwigExtra/config/services.php b/src/TwigExtra/config/services.php
index 59e71897..4c89f374 100644
--- a/src/TwigExtra/config/services.php
+++ b/src/TwigExtra/config/services.php
@@ -11,7 +11,7 @@
 return function (ContainerConfigurator $configurator): void {
     $services = $configurator->services();
 
-    $services->set('twig_extra.twig.extension.test_form_attribute', TestFormAttributeExtension::class)
+    $services->set('sylius_twig_extra.twig.extension.test_form_attribute', TestFormAttributeExtension::class)
         ->args([
             param('kernel.environment'),
             param('kernel.debug'),
diff --git a/src/TwigExtra/src/Twig/Extension/SortByExtension.php b/src/TwigExtra/src/Twig/Extension/SortByExtension.php
index 843ef0b6..871c78a7 100644
--- a/src/TwigExtra/src/Twig/Extension/SortByExtension.php
+++ b/src/TwigExtra/src/Twig/Extension/SortByExtension.php
@@ -18,16 +18,14 @@ public function getFilters(): array
         ];
     }
 
-    /**
-     * @throws NoSuchPropertyException
-     */
+    /** @throws NoSuchPropertyException */
     public function sortBy(iterable $iterable, string $field, string $order = 'ASC'): array
     {
         $array = $this->transformIterableToArray($iterable);
 
         usort(
             $array,
-            function (array|object $firstElement, array|object $secondElement) use ($field, $order) {
+            function (array|object $firstElement, array|object $secondElement): int use ($field, $order) {
                 $accessor = PropertyAccess::createPropertyAccessor();
 
                 $firstProperty = (string) $accessor->getValue($firstElement, $field);
diff --git a/src/TwigExtra/src/Twig/Extension/TestFormAttributeExtension.php b/src/TwigExtra/src/Twig/Extension/TestFormAttributeExtension.php
index 5862c62c..7c84a0ad 100644
--- a/src/TwigExtra/src/Twig/Extension/TestFormAttributeExtension.php
+++ b/src/TwigExtra/src/Twig/Extension/TestFormAttributeExtension.php
@@ -12,13 +12,10 @@ final class TestFormAttributeExtension extends AbstractExtension
     public function __construct(
         private readonly string $environment,
         private readonly bool $isDebugEnabled,
-    )
-    {
+    ) {
     }
 
-    /**
-     * @return TwigFunction[]
-     */
+    /** @return TwigFunction[] */
     public function getFunctions(): array
     {
         return [
diff --git a/src/TwigExtra/src/Twig/Extension/TestHtmlAttributeExtension.php b/src/TwigExtra/src/Twig/Extension/TestHtmlAttributeExtension.php
index e3f1b9e8..70df07ec 100644
--- a/src/TwigExtra/src/Twig/Extension/TestHtmlAttributeExtension.php
+++ b/src/TwigExtra/src/Twig/Extension/TestHtmlAttributeExtension.php
@@ -15,9 +15,7 @@ public function __construct(
     ) {
     }
 
-    /**
-     * @return TwigFunction[]
-     */
+    /** @return TwigFunction[] */
     public function getFunctions(): array
     {
         return [
diff --git a/src/TwigExtra/tests/Unit/Twig/Extension/SortByExtensionTest.php b/src/TwigExtra/tests/Unit/Twig/Extension/SortByExtensionTest.php
index f5fcff31..fb11e04f 100644
--- a/src/TwigExtra/tests/Unit/Twig/Extension/SortByExtensionTest.php
+++ b/src/TwigExtra/tests/Unit/Twig/Extension/SortByExtensionTest.php
@@ -159,7 +159,7 @@ public function testItReturnsInputArrayIfThereIsOnlyOneObjectInside(): void
     {
         $data = [(object) []];
 
-        $this->assertEquals($data, (new SortByExtension())->sortBy($data, 'property'), );
+        $this->assertEquals($data, (new SortByExtension())->sortBy($data, 'property'));
     }
 
     public function testItDoesNothingIfArrayIsEmpty(): void