Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in subscriptions model #82

Open
lukeasrodgers opened this issue Sep 25, 2017 · 0 comments
Open

Bug in subscriptions model #82

lukeasrodgers opened this issue Sep 25, 2017 · 0 comments

Comments

@lukeasrodgers
Copy link

The model and rest client signatures for updating a subscription don't match: the subscriptions rest client expects a subscription_id but the model does not pass it.

rest client: https://github.com/synapsepay/SynapsePayRest-Ruby/blob/01140eeeab22acf697ff0e7208cac9140bb29984/lib/synapse_pay_rest/api/subscriptions.rb#L73

model: https://github.com/synapsepay/SynapsePayRest-Ruby/blob/01140eeeab22acf697ff0e7208cac9140bb29984/lib/synapse_pay_rest/models/subscription/subscription.rb#L81

possibly the rest api function signature should be def update(subscription_id:, **payload)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant