Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft/Xbox/MS Platform #218

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

LizAinslie
Copy link
Member

@LizAinslie LizAinslie commented Jul 28, 2022

Checklist

  • Backend
    • Add Microsoft authentication
    • Fetch Minecraft UUIDs to the account
  • Web
    • Add a button to link MS/Xbox
  • Browser Extension
    • Supported Sites
      • (Optional) Minecraft related sites: Each of these will require getting a Minecraft UUID from the listed username.
        • Hypixel & Other servers as suggested below by the community
        • Spigot, Bukkit, Paper forums
  • Minecraft Mod
    • Forge
    • Fabric
    • (Optional) Just use Architectury. Never used it before, so if it doesn't work well just get rid of this option.

@LizAinslie LizAinslie added enhancement New feature or request java Pull requests that update Java code javascript Pull requests that update Javascript code kotlin Pull requests that update Kotlin code labels Jul 28, 2022
@LizAinslie LizAinslie self-assigned this Jul 28, 2022
@LizAinslie LizAinslie linked an issue Jul 28, 2022 that may be closed by this pull request
@LizAinslie
Copy link
Member Author

LizAinslie commented Jul 28, 2022

I intended to mark this as a draft, oops. Be aware it is not ready to merge and I am actively developing this feature.

@LizAinslie LizAinslie marked this pull request as draft July 28, 2022 20:53
@LizAinslie
Copy link
Member Author

Rocky, I'm just adding you now for later. I'll need someone to approve since I can't shouldn't really approve my own pull :P

@LizAinslie
Copy link
Member Author

@SpicyTakis mentioned to me on Discord that a Spigot(/other server) plugin may also be a good idea. I'll leave it here to collect feedback and tomorrow if this gets more than 3 👍🏻 I'll add it to the list. I'll add my own 👍🏻 since I personally agree with the idea.

My thoughts on display locations are:

  • Tab list
  • Chat
  • Above player heads

These should all be configurable by administrators and we should hook into PAPI as well.

Another consideration is sending a plugin message to any modded clients that have the mod to tell the mod not to render, preferring the server instead.

@LizAinslie
Copy link
Member Author

I've also assigned Takis, since he's expressed interest in the architectury side of things.

@LizAinslie
Copy link
Member Author

Linking only for Minecraft, no login or creation. Thanks to Microsoft it simply isn't feasible to fetch an email.

@SpicyTakis
Copy link

I think having a client mod do most of the stuff would work better due to being able to show stuff on the user. The spigot side of things would work good for adding PAPI hooks and in the tab list, but it wouldn't be desirable for chat due to not being able to edit chat message metadata. It would work for showing their timezone in a UTC-x format but not the current time.

@Rocky43007
Copy link
Member

You wouldn't need to edit chat metadata. The plugin could have a listener for chat messages; we just have to format the chat message with the data (the best case would be hover using CMI). We can also probably have it so that other plugin devs can patch it into their existing systems.

@SpicyTakis
Copy link

I know that you could have a chat listener, but what I meant to say is that showing the actual time is not the best solution because after awhile it will become behind and inaccurate. So showing the timezone would be the best solution for in chat.

@LizAinslie
Copy link
Member Author

a client mod do most of the stuff would work better due to being able to show stuff on the user. The spigot side of things would work good for adding PAPI hooks and in the tab list, but it wouldn't be desirable for chat due to not being able to edit chat message metadata. It would work for showing their timezone in a UTC-x format but not the current time

@SpicyTakis I actually agree here, perhaps it would be best to just write a mod as the server would only have server time to compare with. I'll go ahead and work on setting up the mod in the next hour or so with architechury

@LizAinslie
Copy link
Member Author

We can still do a server plugin but it would only show a timezone as mentioned previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java Pull requests that update Java code javascript Pull requests that update Javascript code kotlin Pull requests that update Kotlin code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minecraft/Xbox/MS Platform
3 participants