Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus Registry is not thread safe #539

Open
Sobeston opened this issue Feb 5, 2025 · 0 comments
Open

Prometheus Registry is not thread safe #539

Sobeston opened this issue Feb 5, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Sobeston
Copy link
Contributor

Sobeston commented Feb 5, 2025

Tsan detected some data races.

Our Registry contains an arena_state: heap.ArenaAllocator. The registry internally locks. However, it then passes .allocator() into other metrics, which do not use this lock.

This requires some reorganisation to fix.
@Sobeston Sobeston added the bug Something isn't working label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Sig
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sobeston