Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an iterator in ForkChoice.getChildren method #556

Open
dadepo opened this issue Feb 10, 2025 · 0 comments
Open

Return an iterator in ForkChoice.getChildren method #556

dadepo opened this issue Feb 10, 2025 · 0 comments

Comments

@dadepo
Copy link
Contributor

dadepo commented Feb 10, 2025

    fn getChildren(
        self: *const ForkChoice,
        slot_hash_key: *const SlotAndHash,
    ) ?SortedMap(SlotAndHash, void) {
        const fork_info = self.fork_infos.get(slot_hash_key.*) orelse return null;
        return fork_info.children;
    }

This should be updated to return an iterator instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant