Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCPi regularisation fails test #832

Closed
2 of 3 tasks
paskino opened this issue Aug 10, 2023 · 5 comments · Fixed by #897
Closed
2 of 3 tasks

CCPi regularisation fails test #832

paskino opened this issue Aug 10, 2023 · 5 comments · Fixed by #897
Assignees
@casperdcl @paskino
Labels
upstream_problem
Milestone
v4.0

Comments

@paskino
Copy link
Contributor

paskino commented Aug 10, 2023 •
edited
Loading

CCPi regularisation toolkit builds but unit tests fail with messages as
#829 (comment)
or

File "/home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/sources/CCPi-Regularisation-Toolkit/test/test_run_test.py", line 5, in <module>
    from ccpi.filters.regularisers import ROF_TV, FGP_TV, PD_TV, SB_TV, TGV, LLT_ROF, FGP_dTV, NDF, Diff4th
  File "/home/runner/install/python/ccpi/filters/regularisers.py", line 5, in <module>
    from ccpi.filters.cpu_regularisers import TV_ROF_CPU, TV_FGP_CPU, TV_PD_CPU, TV_SB_CPU, dTV_FGP_CPU, TNV_CPU, NDF_CPU, Diff4th_CPU, TGV_CPU, LLT_ROF_CPU, PATCHSEL_CPU, NLTV_CPU
ImportError: /home/runner/install/python/ccpi/filters/cpu_regularisers.cpython-310-x86_64-linux-gnu.so: undefined symbol: _Z14SB_TV_CPU_mainPfS_S_fifiiii
@paskino
Copy link
Contributor Author

paskino commented Aug 10, 2023

We should reinstate 90faebc and 6e0b7e3

@paskino paskino mentioned this issue Aug 10, 2023
Merged
@paskino paskino added this to the v3.6 milestone Aug 10, 2023
@paskino
Copy link
Contributor Author

paskino commented Aug 13, 2023

After #829 the ccpi-regularisation is not built as CIL dependency

@casperdcl casperdcl mentioned this issue Oct 31, 2023
Merged
@paskino paskino mentioned this issue Nov 24, 2023
Closed
@casperdcl
Copy link
Member

@paskino I guess you'll push a new toolkit release?

@paskino
Copy link
Contributor Author

paskino commented Mar 20, 2024

Can we just use a different commit hash

@KrisThielemans
Copy link
Member

fine for me

@KrisThielemans KrisThielemans modified the milestones: v3.6, v4.0 Mar 22, 2024
@paskino paskino mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

@paskino paskino

Labels
upstream_problem
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

update CIL and CCPi-Regularisation version and reinstate tests SyneRBI/SIRF-SuperBuild
3 participants
@KrisThielemans @casperdcl @paskino