Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radarr: Update to v5.12.2.9335 #6310

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Nov 8, 2024

Description

This PR includes the following changes:

  1. Update Radarr to v5.12.2.9335 (.NET 6.0.32 compatible with ARMv7)
  2. Include build for Alpine4k (Framework: Update dotnet 6.0 exclusions #6103)

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Package update

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Nov 8, 2024

hey @hgy59, I've tried the build but it fails to run under DSM 6 from a clean install. I get in the service log:

Fri Nov  8 09:18:31 -04 2024
Starting radarr command env HOME=/volume1/@appstore/radarr/var LD_LIBRARY_PATH=/volume1/@appstore/radarr/lib /volume1/@appstore/radarr/share/Radarr/bin/Radarr -nobrowser -data=/volume1/@appstore/radarr/var/.config/Radarr
/volume1/@appstore/radarr/share/Radarr/bin/Radarr: relocation error: /volume1/@appstore/radarr/lib/libpthread.so.0: symbol __tunable_get_val, version GLIBC_PRIVATE not defined in file ld-linux-x86-64.so.2 with link time reference
radarr is not running

@hgy59
Copy link
Contributor

hgy59 commented Nov 8, 2024

@mreid-tt this fix is for all packages running under DSM < 7.2 not only for ARMv7.

It is an issue for all systems running DSM 7.1 and there are evansport (i686), and some x64 models that do not get updates to DSM 7.2
And it is an issue for all systems running DSM 6.2.4.

DSM 7.2 has GLIBC 2.36
DSM 7.1 has GLIBC 2.26, exceot comcerto2k has 2.20
DSM 6.2.4 has GLIBC 2.20, except ARMv5 has 2.15 and ARMv7L has 2.19

so the changelog should tell something like "fix for DSM < 7.2"

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Nov 8, 2024

@hgy59, I'll update the changelog but the solution you proposed by adding cross/glibc to all archs is causing the package to break. Any thoughts on this?

@hgy59
Copy link
Contributor

hgy59 commented Nov 8, 2024

@hgy59, I'll update the changelog but the solution you proposed by adding cross/glibc to all archs is causing the package to break. Any thoughts on this?

does it work on DSM 6 without cross/glibc?

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Nov 8, 2024

does it work on DSM 6 without cross/glibc?

Yes it did previously. The log I supplied for an upgrade of the published package using the built in updater to the same version was successful. I can build a clean install to test but I don't expect the results will be different.

I came across these but it's a bit beyond my expertise:

@hgy59
Copy link
Contributor

hgy59 commented Nov 8, 2024

If Radarr v5.14.0.9383 runs on DSM 6 without cross/glibc we should add glibc for DSM >= 7 only.

But I doubt that it will run on DSM 7.1.
unfortunately cross/glibc has an autogenerated PLIST file, so it is not obvious which libraries come from it.
If it contains libc.so.6 it might be an issue that some dependencies use this from the package library path an other from the system library path.

If /var/packages/radarr/target/lib has any libc.* file (links and content) you might try to delete those to fix it.

@hgy59
Copy link
Contributor

hgy59 commented Nov 8, 2024

I guess my last proposal does not work and the radarr package has to be restricted to DSM 7.2.

Unfortunately we do not have any chance to limit packages that use the package internal updater to limit updates to a specific version (the last version before it breaks).

@hgy59
Copy link
Contributor

hgy59 commented Nov 8, 2024

@mreid-tt and we do not have any package the needs cross/glibc* so far...

So I guess it is not possible to bring your own version of glibc with a package.

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Nov 8, 2024

If Radarr v5.14.0.9383 runs on DSM 6 without cross/glibc we should add glibc for DSM >= 7 only.

But I doubt that it will run on DSM 7.1. unfortunately cross/glibc has an autogenerated PLIST file, so it is not obvious which libraries come from it.

You're correct, I get a similar log when run under DSM 7.1:

Fri Nov  8 10:34:27 -04 2024
Starting radarr command env HOME=/volume1/@appdata/radarr LD_LIBRARY_PATH=/volume1/@appstore/radarr/lib /volume1/@appstore/radarr/share/Radarr/bin/Radarr -nobrowser -data=/volume1/@appdata/radarr/.config/Radarr
/volume1/@appstore/radarr/share/Radarr/bin/Radarr: relocation error: /volume1/@appstore/radarr/share/Radarr/bin/Radarr: symbol __pthread_key_create, version GLIBC_2.2.5 not defined in file libpthread.so.0 with link time reference
radarr is not running

I guess my last proposal does not work and the radarr package has to be restricted to DSM 7.2.

I wouldn't suggest we build only for DSM 7.2 since the problem seems to only exist with ARMv7 platforms. My current course of action is working with the Radarr folks to press Microsoft to fix this upstream: dotnet/runtime#109739. Hopefully a future version of .NET will fix it and we can continue as we have done before.

Unfortunately we do not have any chance to limit packages that use the package internal updater to limit updates to a specific version (the last version before it breaks).

If this is not fixed we can do a workaround like this:

  1. Determine if the build is for ARMv7
  2. If so, build for the last working version
  3. Remove the auto-update file as well as alter the config to turn off automatic updates

@mreid-tt mreid-tt marked this pull request as draft November 8, 2024 14:47
@mreid-tt mreid-tt self-assigned this Nov 8, 2024
@mreid-tt mreid-tt changed the title Radarr: Update to v5.14.0.9383 Radarr: Update to v5.12.2.9335 Nov 20, 2024
@mreid-tt mreid-tt marked this pull request as ready for review November 20, 2024 15:05
@mreid-tt mreid-tt merged commit 0e7763e into SynoCommunity:master Nov 21, 2024
15 checks passed
@mreid-tt mreid-tt deleted the radarr-update branch November 21, 2024 09:11
@mreid-tt mreid-tt added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants