-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 MVP Feature Base #892
Closed
Closed
V3 MVP Feature Base #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add permission management to account * (WIP) Implement permissions based modifier for account * increase packed permission store * Improve Permission identification * cleanup * Add Account delegation operations * Set as Satellite and add Module test * lint * cleanup * more cleanup * rogue copypasta * add draft API for account and fund * reduce PR to just bootstrap the module and satellite
* initial commit * cleanup satellite stuff
* initial commit * move error definition to AccountBase * added basic stuff for fund * add some comments * remove dependency on accountBase for the moment * wip - add more logic to account * more updates * cleanup Account * define basics fund storage * Make it compile and deploy * basic SIP interface coverage * pair programming storage and some logic * Account Code compiling * Add enabled Collateral Types * bootstrap test * some logs cleanup * extend deploy test timeout * add some tests structure * staking and unstaking happy path * cleanup * lint * add more tests
* initial commit * more coding... * fix some errors * make it compile * correct transfer ownership signature on fund token * some accounting logic * Add more logic and make it compile * remove duplicated function * Start CollateralModule migration from account * add collateralModule test * refactor WIP * (WIP) is deployable * add some comments to Collateral Module * split account test * add RBAC tests to account * bootstrap RBACMixin test * complete tests for RBAC Mixin * Complete Collateral Module SCCP test * Add missing tests to AccountModuleToken * Fix CollateralModule Stake * Lint + cleanup * fundToken prevent transferFrom and allow coordinated ownership transfer * Test for FundModule Token (Ownership) * remove link between the owner on the FundToken and FundModule * bootstrap funds (functionality) test * more tests and get fund positions * Add tests to cover one account liquidity changes * some cleanup * lint * Collateral SCCP fixed * some fixes from feedback * make tests pass * Fund SCCP add coverage, some errors and events * cleanup some TODOs * add collateralMixin * Lint + make tests pass again * add code for minting and burning sUSD * clean up some variables * add comments and reorder * duh
Codecov Report
@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 98.08% 98.97% +0.88%
==========================================
Files 92 24 -68
Lines 1515 389 -1126
Branches 119 0 -119
==========================================
- Hits 1486 385 -1101
+ Misses 29 4 -25
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
* add utils * lint * PR fix * lint
* Initial commit * fix tests
* first commit * add missing hidratation
* mintNext function * fix lint * Apply suggestions from code review Co-authored-by: Leonardo Massazza <[email protected]>
* Initial commit * make tests pass * add sUSD token and mint/burn from fund * pr updates * fix test * make test work * rename FundSCCP to FundConfiguration
* fixed first issue * fix cannonfile build * v 0.7 * version fix * progress * working
* market module WIP * fix tests - add setAllowance * lint * wip * wip rename sUSD to USD * started liquidations * wip * wip * move curve to library; make it compile * make tests great again * change return value to CollateralData * implement registerMarket * improve MathUtil * wip * update cannon version * link Fund to MarketManager * fix test * add tests to MathUtil lib * overload functions for uint and int * cleanup and order parameters * Remove supplyTarget and order/rename variables * Document interfaces * start testing MarketManager * Add test * add fundMaxDebtShare (supplyTarget cap) * add functionality to MarketMock * bootstrap whole system test * more tests * update cannon version Co-authored-by: Noah Litvin <[email protected]>
* add contract * add hooks * fix prettier * code review fixes * remove interface inheritence * tests * remove only * fix nit
* cannon and test fix * fix test
@leomassazza Can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #894