Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Folder unwrap causes crashing #28

Open
hackgrid opened this issue May 23, 2024 · 11 comments
Open

[BUG] Folder unwrap causes crashing #28

hackgrid opened this issue May 23, 2024 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@hackgrid
Copy link

Describe the bug
I want to transfer my Samsung Galaxy Tab S4 to my PC.
I choose "Unwrap folders on copy" and transferred all folders at once.

Unhandled exception log
See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at AdbFileManager.Functions.isFolder(String path, Boolean old_android) in C:\Users\user\source\repos\AdbFileManager\AdbFileManager\Form1.cs:line 664
at AdbFileManager.Form1.android2pc_Click(Object sender, EventArgs e) in C:\Users\user\source\repos\AdbFileManager\AdbFileManager\Form1.cs:line 232
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(HWND hWnd, MessageId msg, WPARAM wparam, LPARAM lparam)

************** Loaded Assemblies **************
System.Private.CoreLib
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Private.CoreLib.dll

AdbFileManager
Assembly Version: 1.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\AdbFileManager.dll

System.Runtime
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Runtime.dll

System.Windows.Forms
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Windows.Forms.dll

System.Windows.Forms.Primitives
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Windows.Forms.Primitives.dll

System.ComponentModel.Primitives
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.ComponentModel.Primitives.dll

System.Drawing.Primitives
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Drawing.Primitives.dll

System.Collections.Specialized
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Collections.Specialized.dll

System.Drawing.Common
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Drawing.Common.dll

System.Runtime.InteropServices
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Runtime.InteropServices.dll

System.Threading
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Threading.dll

System.Diagnostics.TraceSource
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Diagnostics.TraceSource.dll

System.Collections
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Collections.dll

System.Data.Common
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Data.Common.dll

System.ComponentModel.TypeConverter
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.ComponentModel.TypeConverter.dll

System.ComponentModel
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.ComponentModel.dll

System.Xml.ReaderWriter
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Xml.ReaderWriter.dll

System.Private.Xml
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Private.Xml.dll

System.Console
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Console.dll

Microsoft.Win32.Primitives
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\Microsoft.Win32.Primitives.dll

System.ComponentModel.EventBasedAsync
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.ComponentModel.EventBasedAsync.dll

System.Threading.Thread
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Threading.Thread.dll

Accessibility
Assembly Version: 4.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\Accessibility.dll

System.Configuration.ConfigurationManager
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Configuration.ConfigurationManager.dll

System.ObjectModel
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.ObjectModel.dll

System.Private.Uri
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Private.Uri.dll

System.Security.Cryptography
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Security.Cryptography.dll

System.Collections.Concurrent
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Collections.Concurrent.dll

System.Memory
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Memory.dll

System.Net.WebClient
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Net.WebClient.dll

System.Text.Encoding.Extensions
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Text.Encoding.Extensions.dll

System
Assembly Version: 4.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.dll

System.Runtime.Serialization.Formatters
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Runtime.Serialization.Formatters.dll

System.Xml.XmlSerializer
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Xml.XmlSerializer.dll

Microsoft.WindowsAPICodePack.Shell
Assembly Version: 7.0.4.0
Location: C:\Users\user\Downloads\adb.file.manager\Microsoft.WindowsAPICodePack.Shell.dll

Microsoft.WindowsAPICodePack.Core
Assembly Version: 7.0.4.0
Location: C:\Users\user\Downloads\adb.file.manager\Microsoft.WindowsAPICodePack.Core.dll

System.Runtime.Loader
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Runtime.Loader.dll

System.Numerics.Vectors
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Numerics.Vectors.dll

Microsoft.Win32.SystemEvents
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\Microsoft.Win32.SystemEvents.dll

System.Resources.Extensions
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Resources.Extensions.dll

System.Drawing
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Drawing.dll

AdbFileManager.resources
Assembly Version: 1.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\en\AdbFileManager.resources.dll

System.Linq
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Linq.dll

System.Runtime.Numerics
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Runtime.Numerics.dll

System.Threading.ThreadPool
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Threading.ThreadPool.dll

System.Collections.NonGeneric
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Collections.NonGeneric.dll

Microsoft.Win32.Registry
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\Microsoft.Win32.Registry.dll

System.Diagnostics.Process
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Diagnostics.Process.dll

System.Text.RegularExpressions
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Text.RegularExpressions.dll

System.Diagnostics.StackTrace
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Diagnostics.StackTrace.dll

System.Reflection.Metadata
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Reflection.Metadata.dll

System.Collections.Immutable
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.Collections.Immutable.dll

System.IO.MemoryMappedFiles
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.IO.MemoryMappedFiles.dll

System.IO.Compression
Assembly Version: 8.0.0.0
Location: C:\Users\user\Downloads\adb.file.manager\System.IO.Compression.dll

************** JIT Debugging **************

To Reproduce

Expected behavior
To copy without error.

Screenshots
grafik

Desktop (please complete the following information):
Windows 10

Additional context

@hackgrid hackgrid added the bug Something isn't working label May 23, 2024
@nadr21a21
Copy link

I'm having the same problem here, did you find a solution? @T0biasCZe
@hackgrid

@hackgrid
Copy link
Author

No, I gave up...

@nadr21a21
Copy link

No, I gave up...

Do you have an alternative with the same I mean software with the same working system ? @hackgrid

@yw-tsikin
Copy link

I also encountered this bug, but what I tried is unchecking the unwrap folders on Copy then there it copied. (What's the purpose of Unwrapping the Folders on copy anyway?)
But is there any fix yet?

@T0biasCZe
Copy link
Owner

T0biasCZe commented Jun 25, 2024

(What's the purpose of Unwrapping the Folders on copy anyway?)4

smoother progressbar, since instead of copying the whole folder as 1 item, it unwraps them as individual files, so they then get individually copied and the progressbar is smoother

@SELEKCJONER
Copy link

is it possible to disable that
i have about 13k folders each has a sub folder with files they take about 10 GB in total
unwrapping all of that takes too much time
so much that i never was able to actually copy my files i always were stuck at unwrapping

@SELEKCJONER
Copy link

using adb pull directly confirms that unwrapping is extremly inefficient
adb pull for whole folder on my phone started copying and finished in less time than i wasted waiting for folder unwrapping

@hackgrid
Copy link
Author

Just use ADB-Explorer guys, it is way better!
https://github.com/Alex4SSB/ADB-Explorer

@T0biasCZe
Copy link
Owner

T0biasCZe commented Jul 26, 2024

is it possible to disable that

image
disable the checkbox and it will copy normally, everything at once

@T0biasCZe
Copy link
Owner

(What's the purpose of Unwrapping the Folders on copy anyway?)

smoother progressbar, since instead of copying the whole folder as 1 item, it unwraps them as individual files, so they then get individually copied and the progressbar is smoother

Unwrap.on.vs.Off.mp4

@yw-tsikin
Copy link

(What's the purpose of Unwrapping the Folders on copy anyway?)

smoother progressbar, since instead of copying the whole folder as 1 item, it unwraps them as individual files, so they then get individually copied and the progressbar is smoother

Unwrap.on.vs.Off.mp4

this is actually much better and faster copying. It may freeze but dont worry because it's still copying on background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants