From 28dc753064625962f5655786a98afd38c888b34f Mon Sep 17 00:00:00 2001
From: AShiningRay <genesis45.ppc@gmail.com>
Date: Tue, 19 Nov 2024 15:04:08 -0300
Subject: [PATCH] PlatformPlayer: Handle midi player creation and volume
 differently

Might as well redo all of this, as the creation was the only part
that was still from the "older" FreeJ2ME implementation. Rework
this here to account better for the custom soundfont, and also
to have its critical bits available when needed for control and
such.
---
 src/org/recompile/mobile/PlatformPlayer.java | 70 +++++++++++---------
 1 file changed, 38 insertions(+), 32 deletions(-)

diff --git a/src/org/recompile/mobile/PlatformPlayer.java b/src/org/recompile/mobile/PlatformPlayer.java
index 84bb6bb7..243c679b 100644
--- a/src/org/recompile/mobile/PlatformPlayer.java
+++ b/src/org/recompile/mobile/PlatformPlayer.java
@@ -30,9 +30,11 @@
 import javax.sound.midi.MidiEvent;
 import javax.sound.midi.MidiSystem;
 import javax.sound.midi.MidiUnavailableException;
+import javax.sound.midi.Receiver;
 import javax.sound.midi.Sequence;
 import javax.sound.midi.Sequencer;
 import javax.sound.midi.ShortMessage;
+import javax.sound.midi.Synthesizer;
 import javax.sound.midi.SysexMessage;
 import javax.sound.midi.Track;
 import javax.sound.sampled.AudioFormat;
@@ -362,18 +364,30 @@ private class midiPlayer extends audioplayer
 		private byte[] stream;
 		private Sequencer midi;
 		private Sequence midiSequence;
+		private Synthesizer synthesizer;
+		private Receiver receiver;
 
-		public midiPlayer(InputStream stream)
+		public midiPlayer(InputStream stream) 
 		{
-			try
+			try 
 			{
-				/* Open the midi stream without a receiver, so that we can load up the custom soundfont if available */
 				midi = MidiSystem.getSequencer(false);
 				this.stream = copyMediaData(stream);
-			}
-			catch (Exception e) 
-			{ 
-				Mobile.log(Mobile.LOG_ERROR, PlatformPlayer.class.getPackage().getName() + "." + PlatformPlayer.class.getSimpleName() + ": " + "Couldn't load midi file:" + e.getMessage());
+
+				if (Manager.useCustomMidi && Manager.hasLoadedCustomMidi) 
+				{
+					synthesizer = Manager.customSynth; // Use the custom synthesizer
+				} else 
+				{
+					synthesizer = MidiSystem.getSynthesizer(); // Default synthesizer
+				}
+				
+				synthesizer.open();
+				receiver = synthesizer.getReceiver();
+				midi.getTransmitter().setReceiver(receiver);
+			} catch (Exception e) 
+			{
+				Mobile.log(Mobile.LOG_ERROR, PlatformPlayer.class.getPackage().getName() + "." + PlatformPlayer.class.getSimpleName() + ": " + "Couldn't load MIDI file: " + e.getMessage());
 			}
 		}
 
@@ -382,15 +396,6 @@ public void realize()
 			try 
 			{ 
 				midi.open();
-				if(Manager.useCustomMidi && Manager.hasLoadedCustomMidi) 
-				{
-					midi.getTransmitter().setReceiver(Manager.customSynth.getReceiver()); 
-				}
-				else
-				{
-					midi.getTransmitter().setReceiver(MidiSystem.getReceiver());
-				}
-
 				/* Make a new copy of the media stream, as realize() can be called more than once during the player's lifecycle */
 				midiSequence = MidiSystem.getSequence(new ByteArrayInputStream(stream));
 				midi.setSequence(midiSequence);
@@ -475,6 +480,8 @@ public long setMediaTime(long now)
 		public long getDuration() { return midi.getMicrosecondLength(); }
 
 		public boolean isRunning() { return midi.isRunning(); }
+
+		public Receiver getReceiver() { return receiver; }
 	}
 
 	private class wavPlayer extends audioplayer
@@ -918,25 +925,24 @@ public int setLevel(int level)
 			 * from only making effective changes if needed.
 			 */
 
-			if(player instanceof midiPlayer) 
+			if (player instanceof midiPlayer) 
 			{
-				
 				midiPlayer sequencer = (midiPlayer) player;
-				int midiVolume = isMuted() ? 0: (int) (this.level * 127 / 100);
-
-				/* Set volume for all channels, through Control Change command 7 */
-				for (Track track : sequencer.midiSequence.getTracks())
+				int midiVolume = isMuted() ? 0 : (int) (this.level * 127 / 100); // Convert to MIDI volume range
+			
+				// Set volume for all channels through Control Change command 7
+				for (int channel = 0; channel < 16; channel++) 
 				{
-					for (int i = 0; i < 16; i++)
-						{
-							/* 
-							 * This will make it so that volume changes take effect at the start of the midi stream.
-							 * As far as i could test, all jars that have volume adjustment seem to start their streams
-							 * from the very beginning after the volume is changed, so this is probably safe.
-							 */
-							try {track.add(new MidiEvent(new ShortMessage(ShortMessage.CONTROL_CHANGE, i, 7, midiVolume), 0)); }
-							catch (Exception e) { Mobile.log(Mobile.LOG_ERROR, PlatformPlayer.class.getPackage().getName() + "." + PlatformPlayer.class.getSimpleName() + ": " + "Midi setLevel failed: " + e.getMessage());}
-						}
+					try 
+					{
+						ShortMessage volumeMessage = new ShortMessage();
+						volumeMessage.setMessage(ShortMessage.CONTROL_CHANGE, channel, 7, midiVolume); // Control Change 7 for volume
+						sequencer.getReceiver().send(volumeMessage, -1); // Send message to the receiver
+					} 
+					catch (Exception e) 
+					{
+						Mobile.log(Mobile.LOG_ERROR, PlatformPlayer.class.getPackage().getName() + "." + PlatformPlayer.class.getSimpleName() + ": " + "Midi setLevel failed: " + e.getMessage());
+					}
 				}
 			}
 			else if(player instanceof wavPlayer) /* Haven't found a jar that actually makes use of this yet - Scratch that: Shadow Shoot again */