Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI artifacts from pull requests fail to get uploaded #22

Closed
vadosnaprimer opened this issue Oct 21, 2024 · 5 comments · Fixed by #15 or #28
Closed

CI artifacts from pull requests fail to get uploaded #22

vadosnaprimer opened this issue Oct 21, 2024 · 5 comments · Fixed by #15 or #28

Comments

@vadosnaprimer
Copy link

https://github.com/TASEmulators/freej2me-plus/actions/runs/11212278346/job/31841764779?pr=15

Error: The artifact name is not valid: freej2me-refs/pull/15/merge-dc15112. Contains the following character: Forward slash /

@AShiningRay
Copy link
Collaborator

That's uh... not a bug in the tree. You're trying to run a build from a branch that now has conflicts with the main tree (gotta thank the major sound system rewrite for that), hence the weird artifact name, as it can't just rebase it automatically into the tree to follow through.

@vadosnaprimer
Copy link
Author

Oh! Thanks!

@vadosnaprimer
Copy link
Author

Hmm same issue with another PR, again the problem is having a slash in the name. The build is fine this time.

@AShiningRay
Copy link
Collaborator

Hmm same issue with another PR, again the problem is having a slash in the name. The build is fine this time.

Eh, i'd just ignore the final result of the CI, as it tries to publish artifacts as well. If the build step goes through, that's all that matters as far as the CI check is concerned.

@vadosnaprimer
Copy link
Author

The good thing about PR artifacts is ability to test them right away, and even people without build env can do it. So I'd say it's valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants