Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test against a local copy of the dwn server #161

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

finn-block
Copy link
Member

@finn-block finn-block commented Jul 31, 2023

use a local dwn-server instance for CI tests

browser tests in CI failing due to slow github runners. does not fail locally.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #161 (d44b4a9) into main (d8e2be7) will increase coverage by 7.99%.
Report is 12 commits behind head on main.
The diff coverage is 90.14%.

❗ Current head d44b4a9 differs from pull request most recent head 35d72dd. Consider uploading reports for the commit 35d72dd to get more accurate results

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   82.28%   90.28%   +7.99%     
==========================================
  Files          68       63       -5     
  Lines        6814    11592    +4778     
  Branches      566     1132     +566     
==========================================
+ Hits         5607    10466    +4859     
+ Misses       1205     1106      -99     
- Partials        2       20      +18     
Components Coverage Δ
api 95.05% <95.05%> (∅)
common 95.00% <75.65%> (-5.00%) ⬇️
credentials ∅ <ø> (∅)
crypto 94.87% <88.95%> (-0.37%) ⬇️
dids 92.16% <ø> (+41.96%) ⬆️
agent 89.18% <89.79%> (∅)
identity-agent 60.50% <ø> (∅)
proxy-agent 60.00% <ø> (∅)
user-agent 58.67% <ø> (∅)

@finn-block finn-block changed the title test against a local copy of the dwn server draft: test against a local copy of the dwn server Aug 4, 2023
@finn-block finn-block marked this pull request as draft August 4, 2023 16:49
@finn-block finn-block changed the title draft: test against a local copy of the dwn server test against a local copy of the dwn server Aug 4, 2023
@finn-block finn-block force-pushed the test-against-local-services branch 2 times, most recently from 1319a44 to 4b43e97 Compare August 4, 2023 19:42
@finn-block finn-block marked this pull request as ready for review August 4, 2023 19:43
@finn-block finn-block force-pushed the test-against-local-services branch 2 times, most recently from 4675325 to c15c307 Compare August 4, 2023 21:01
@finn-block finn-block marked this pull request as draft August 4, 2023 21:02
@finn-block
Copy link
Member Author

bundling changes merged and broke some stuff, I have put this back into draft state

frankhinek added a commit that referenced this pull request Aug 20, 2023
frankhinek added a commit that referenced this pull request Aug 20, 2023
@frankhinek frankhinek mentioned this pull request Aug 20, 2023
frankhinek added a commit that referenced this pull request Aug 21, 2023
@finn-block finn-block force-pushed the test-against-local-services branch 4 times, most recently from b5a9925 to 54ceda2 Compare August 21, 2023 20:06
* tests check for environment variable DWN_URL and use that as the dwn server if specified
* dwn-server launched in docker container during tests, DWN_URL is set
@finn-block finn-block marked this pull request as ready for review August 22, 2023 19:01
Copy link
Contributor

@frankhinek frankhinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this PR is passing all tests locally, node tests pass in GitHub CI and browser tests in GitHub CI all pass... but return a failure due to Error: Process completed with exit code 1.

@finn-block finn-block merged commit 1d2cc96 into main Aug 22, 2023
19 of 23 checks passed
@frankhinek frankhinek deleted the test-against-local-services branch August 23, 2023 09:31
andorsk pushed a commit to modernfoundry/web5-js that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants