Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bwce-role.yaml over eager #104

Open
g-bohncke opened this issue Oct 11, 2024 · 0 comments
Open

bwce-role.yaml over eager #104

g-bohncke opened this issue Oct 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@g-bohncke
Copy link

g-bohncke commented Oct 11, 2024

The role defined here https://github.com/TIBCOSoftware/tp-helm-charts/blob/main/charts/dp-configure-namespace/templates/bwce-role.yaml is a bit over eager mapping all options of ingress controllers.

- apiGroups: ["networking.k8s.io"]
  resources: ["ingresses"]
  verbs: ["list", "get", "create", "update", "delete"]
- apiGroups: ["configuration.konghq.com"]
  resources: ["kongplugins"]
  verbs: ["list", "get", "create", "update", "delete"]
- apiGroups: ["traefik.io"]
  resources: ["middlewares"]
  verbs: ["list", "get", "create", "update", "delete", "patch"

I would advice to put if statements around this and requite the values to specify the ingress controller of choice to be used. because their might be customers out that that run multiple ingress controllers in the same cluster but want tibco to only have privileges to one.

@ygirey ygirey added the enhancement New feature or request label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants