Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TLNBS2405/heihachi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d213f004347fe80d07ed3e5bc38ae36ed024c7ac
Choose a base ref
..
head repository: TLNBS2405/heihachi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8584a73209f85472d54706bc2773d9e0fde40422
Choose a head ref
Showing with 3 additions and 7 deletions.
  1. +2 −2 src/framedb/tests/test_framedb.py
  2. +1 −5 src/heihachi/bot.py
4 changes: 2 additions & 2 deletions src/framedb/tests/test_framedb.py
Original file line number Diff line number Diff line change
@@ -299,9 +299,9 @@ def test_get_move_by_frame_startup(frameDb: FrameDb) -> None:

assert set(move_ids) == set(expected_move_ids)


def test_get_move_by_frame_no_results(frameDb: FrameDb) -> None:
returned_moves = frameDb.get_move_by_frame(CharacterName.RAVEN, "<", 1, FrameSituation.STARTUP)
move_ids = list(map(lambda move: move.id, returned_moves))
expected_move_ids = []
expected_move_ids: list[str] = []
assert set(move_ids) == set(expected_move_ids)

6 changes: 1 addition & 5 deletions src/heihachi/bot.py
Original file line number Diff line number Diff line change
@@ -35,11 +35,7 @@ def __init__(

self._add_bot_commands()
char_names = [char.value for char in CharacterName]
flattened_aliases = [
alias
for sublist in CHARACTER_ALIAS.values()
for alias in sublist
]
flattened_aliases = [alias for sublist in CHARACTER_ALIAS.values() for alias in sublist]
char_names_and_alias = set(char_names + flattened_aliases)
for char in char_names_and_alias:
self.tree.command(name=char, description=f"Frame data from {char}")(self._character_command_factory(char))