Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate files from merge conflicts #141

Open
codykallen opened this issue Mar 11, 2019 · 4 comments
Open

Duplicate files from merge conflicts #141

codykallen opened this issue Mar 11, 2019 · 4 comments
Labels
question Further information is requested

Comments

@codykallen
Copy link
Collaborator

It appears that you've had some merge conflicts in your recent work, that have been "resolved" by producing unnecessary files. Looking at the files in taxcalc, I believe the following list includes all of the files produced by merge conflicts. For each group, we need to figure out which one is correct and remove the others.

  • current_law_policy.json, current_law_policy1.json, current_law_policy2.json, current_law_policy3.json, current_law_policy_pit_cit.json
  • functions.py, functions1.py, functions2.py, functions3.py
  • gst.csv, gst_updated.csv, gst1.csv, gst2.csv
  • gst_weights.csv, gst_weights1.csv
  • gst_records.py, gst_records1.py
  • gstrecords_variables.json, gstrecords_variables1.json

@martinholmer @sebastiansajie

@sebastiansajie
Copy link
Collaborator

@codykallen , unfortunately during one of the issues i had with syncing with github, all my local files got uploaded into the repository. I need to clean it up.

@sebastiansajie
Copy link
Collaborator

sebastiansajie commented Mar 11, 2019

@codykallen current_law_policy_pit_cit.json is a required file. This is used to generate the current_law_policy.json that combines the pit, cit and gst policies. I have deleted the others.

@codykallen
Copy link
Collaborator Author

@sebastiansajie has removed most of the extra files. Are the following also duplicates from merge conflicts?

  • gst.csv and gst_updated.csv
  • gst_weights.csv and gst_weights1.csv

@martinholmer
Copy link
Collaborator

@codykallen said several months ago in issue #141:

@sebastiansajie has removed most of the extra files.
Are the following also duplicates from merge conflicts?

  • gst.csv and gst_updated.csv
  • gst_weights.csv and gst_weights1.csv

@sebastiansajie, is there a need for more cleanup? If so, I'd be happy to help.

I can't find anywhere in the top-level app*py files or in the lower-level taxcalc code any use of gst_updated.csv. Do you want me to remove the gst_updated.csv file from the repository?

And I can't find anywhere in the top-level app*py files or in the lower-level taxcalc code any use of gst_weights1.csv. Do you want me to remove the gst_weights1.csv file from the repository?

@martinholmer martinholmer added the question Further information is requested label Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants