Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookahead should respect predefined scores even if the solution is suboptimal #30

Open
stheid opened this issue Dec 7, 2023 · 0 comments

Comments

@stheid
Copy link
Contributor

stheid commented Dec 7, 2023

len_pre = min(len(set(predef_features) & remaining_features), len_)
len_rest = len_ - len_pre
if strict and predef_features:
prefixes = [
[f_ for f_ in predef_features if f_ in remaining_features][:len_pre]
]
else:
prefixes = permutations(
set(predef_features) & remaining_features, len_pre
)

lookahead should not consider any additional features for selection untill the prefix is exausted.

maybe that is already the case, and maybe we need the lookahead regardless because we might need to lookahead when selecting the score for the current feature.

just needs to be checked, as it might save runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant