Use toast notification syntax to support actions on Win32 #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupaschoal
force-pushed
the
update-notification
branch
from
8f033cc to
5ac054d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
+ Coverage 79.37% 79.40% +0.03%
==========================================
Files 21 21
Lines 1275 1277 +2
Branches 189 189
==========================================
+ Hits 1012 1014 +2
Misses 263 263 ☔ View full report in Codecov by Sentry. |
|
@tupaschoal looks like the tests failed |
tupaschoal
force-pushed
the
update-notification
branch
from
5ac054d to
95e521b
Compare
|
@araujoarthur0 should be fine now, since we changed the way that win32 notifications are created, I needed to check different notification parameters for the tests |
|
\changelog-update |
|
\changelog-update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / Background
@ochan12 had kindly introduced the more modern notification syntax for Win32 when we eventually upgraded electron
What change is being introduced by this PR?
Updating the notification syntax, fixing some of the code that was previously there. For some reason, the button text only works if the variable is assigned first:
How will this be tested?
Tested it locally, but I'm not 100% sure it works