Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add estimated break time to time to leave #1075

Open
dimateos opened this issue Aug 30, 2024 · 2 comments
Open

Add estimated break time to time to leave #1075

dimateos opened this issue Aug 30, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dimateos
Copy link

Describe the current limitation
Current estimated time to leave is misleading if you have an enforced minimum break time.

Describe the proposed feature or enhancement
Take into account break time for the estimated time to leave. Add an option to toggle this for users that prefer the previous behavior.

@dimateos dimateos added the enhancement New feature or request label Aug 30, 2024
@yellowstrings
Copy link

working on this currently!

@tupaschoal
Copy link
Collaborator

#1083 had a go at a solution, but the ultimate one needs to account for more things. Today we have two scenarios on the app:

  1. No enforced break time
  2. Enforced break time

On both scenarios, the "Leave by" is properly updated as soon as the break has been finished/computed, which for the first is when the user punches back and for the second is as soon as they punch out to begin the break.

We cannot do any better for scenario 1 in terms of estimating the "Leave by", since we cannot now the break time, but for the second scenario we can. To be fully functional, it does bring some more complex questions:

  1. How many enforced breaks does the user have? We currently consider only one (which is by default how many breaks are there on the screen). It can prefill if the user has previously added more empty entries.
  2. Does the user have a number of enforced breaks and non-enforced?

That brings the question of maybe bringing in an additional preference of "number of enforced breaks". This would make it easier to automatically input the breaks for case option 1 and also to know when to stop inputting it if the scenario 2 happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants