Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback language es? #896

Open
ochan12 opened this issue Nov 2, 2022 · 1 comment
Open

Fallback language es? #896

ochan12 opened this issue Nov 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@ochan12
Copy link
Contributor

ochan12 commented Nov 2, 2022

Describe the proposed feature or enhancement
Even though I'm flattered 🇦🇷 that fallback language is Spanish for i18n, I'm not completely sure this is desired behaviour since TTL's name is in english and it looks that the base language is english. In that case the fallback language should change to en.

image
@ochan12 ochan12 added the enhancement New feature or request label Nov 2, 2022
sisir-umich added a commit to sisir-umich/time-to-leave that referenced this issue Nov 8, 2022
@sisir-umich
changed fallbackLng to en from es to address issue TTLApp#896
c90a5db
@sisir-umich sisir-umich mentioned this issue Nov 8, 2022
Closed
1 task
@araujoarthur0
Copy link
Collaborator

I'm not sure I remember the reasoning for this, but could it be that "en" is like the default language, and then "es" is just the fallback to the default "en"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #896: fallbackLng should be English sisir-umich/time-to-leave
2 participants
@ochan12 @araujoarthur0